Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bugfix] BigNumber crash, Horizon indent and Myanmar geojson #5746

Merged
merged 3 commits into from
Aug 27, 2018
Merged

[bugfix] BigNumber crash, Horizon indent and Myanmar geojson #5746

merged 3 commits into from
Aug 27, 2018

Conversation

kristw
Copy link
Contributor

@kristw kristw commented Aug 27, 2018

  • Fix big_number_total crashes because formData.color_picker is undefined.
  • Fix invalid Myanmar geojson
  • Remove unintentional indent for horizon chart label for each row when in dashboard.

@williaster @graceguo-supercat @hughhhh

@hughhhh hughhhh self-assigned this Aug 27, 2018
@hughhhh hughhhh self-requested a review August 27, 2018 22:44
@hughhhh hughhhh removed their assignment Aug 27, 2018
hughhhh
hughhhh approved these changes Aug 27, 2018
View reviewed changes
Copy link
Member

@hughhhh hughhhh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@hughhhh
Copy link
Member

hughhhh commented Aug 27, 2018 •
edited
Loading

Whoops thanks for the save @kristw , I'll merge with a green CI

@hughhhh hughhhh merged commit 0781cf2 into apache:master Aug 27, 2018
@codecov-io
Copy link

codecov-io commented Aug 27, 2018 •
edited
Loading

Codecov Report

Merging #5746 into master will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5746      +/-   ##
==========================================
- Coverage   63.45%   63.44%   -0.01%     
==========================================
  Files         362      362              
  Lines       22978    22980       +2     
  Branches     2554     2555       +1     
==========================================
  Hits        14580    14580              
- Misses       8383     8385       +2     
  Partials       15       15
Impacted Files Coverage Δ
superset/assets/src/visualizations/BigNumber.jsx 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d01c84...d7279a4. Read the comment docs.

kristw added a commit to kristw/incubator-superset that referenced this pull request Aug 27, 2018
@kristw
[bugfix] BigNumber crash, Horizon indent and Myanmar geojson (apache#…
0d3baae 
…5746)

* fix myanmar geojson

* fix indent of horizon in dashboard

* Fix bignumber crash when color_picker is undefined

(cherry picked from commit 0781cf2)
@kristw kristw mentioned this pull request Aug 27, 2018
Merged
@kristw kristw deleted the kristw-fix-little-things branch August 28, 2018 17:10
@kristw kristw mentioned this pull request Aug 30, 2018
Closed
3 tasks
betodealmeida pushed a commit to lyft/incubator-superset that referenced this pull request Oct 12, 2018
@kristw @betodealmeida
[bugfix] BigNumber crash, Horizon indent and Myanmar geojson (apache#…
7d632ac 
…5746)

* fix myanmar geojson

* fix indent of horizon in dashboard

* Fix bignumber crash when color_picker is undefined
wenchma pushed a commit to wenchma/incubator-superset that referenced this pull request Nov 16, 2018
@kristw @hughhhh
[bugfix] BigNumber crash, Horizon indent and Myanmar geojson (apache#…
9edf701 
…5746)

* fix myanmar geojson

* fix indent of horizon in dashboard

* Fix bignumber crash when color_picker is undefined
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.28.0 labels Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hughhhh hughhhh hughhhh approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.28.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kristw @hughhhh @codecov-io @mistercrunch