Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bugfix] BigNumber crash, Horizon indent and Myanmar geojson #5746

Merged
merged 3 commits into from
Aug 27, 2018
Merged

[bugfix] BigNumber crash, Horizon indent and Myanmar geojson #5746

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
867f843
fix myanmar geojson
kristw Aug 27, 2018
9312798
fix indent of horizon in dashboard
kristw Aug 27, 2018
d7279a4
Fix bignumber crash when color_picker is undefined
kristw Aug 27, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions superset/assets/src/visualizations/BigNumber.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,14 +231,17 @@ BigNumberVis.defaultProps = defaultProps;
function adaptor(slice, payload) {
const { formData, containerId } = slice;
const { data, subheader, compare_suffix: compareSuffix } = payload.data;
const { r, g, b } = formData.color_picker;
const compareLag = Number(payload.data.compare_lag);
const supportTrendline = formData.viz_type === 'big_number';
const showTrendline = supportTrendline && formData.show_trend_line;
const startYAxisAtZero = formData.start_y_axis_at_zero;
const formatValue = d3FormatPreset(formData.y_axis_format);
const bigNumber = supportTrendline ? data[data.length - 1][1] : data[0][0];
const userColor = color.rgb(r, g, b).hex();
let userColor;
if (formData.color_picker) {
const { r, g, b } = formData.color_picker;
userColor = color.rgb(r, g, b).hex();
}

let percentChange = 0;
let formattedSubheader = subheader;
Expand Down
3 changes: 2 additions & 1 deletion superset/assets/src/visualizations/HorizonChart.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,10 @@
margin: 0px;
}

.horizon-row span {
.horizon-row span.title {
position: absolute;
color: #333;
font-size: 0.8em;
margin: 0;
text-shadow: 1px 1px rgba(255, 255, 255, 0.75);
}
Loading