Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: don't show query overlay when panning mapbox maps #5814

Merged

Conversation

xtinec
Copy link
Contributor

@xtinec xtinec commented Sep 4, 2018

Since we don't want to prompt user to rerun query every time they pan a map, prevent the query overlay from showing by setting dontRefreshOnChange in for viewport_latitude and viewport_longitude controls.

👀 @mistercrunch @betodealmeida

@codecov-io
Copy link

codecov-io commented Sep 4, 2018

Codecov Report

Merging #5814 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5814   +/-   ##
=======================================
  Coverage   63.82%   63.82%           
=======================================
  Files         364      364           
  Lines       23099    23099           
  Branches     2587     2587           
=======================================
  Hits        14744    14744           
  Misses       8340     8340           
  Partials       15       15
Impacted Files Coverage Δ
superset/assets/src/explore/controls.jsx 46.26% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb41756...cc44ec5. Read the comment docs.

Since we don't want to prompt user to rerun query every time they pan a map, prevent the query overlay from showing by setting dontRefreshOnChange for viewport_latitude and viewport_longitude controls.
@xtinec xtinec force-pushed the xtinec/do-not-show-overlay-when-panning-map branch from 56b4d81 to cc44ec5 Compare September 4, 2018 22:58
Copy link
Member

@betodealmeida betodealmeida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@betodealmeida betodealmeida merged commit a411516 into apache:master Sep 5, 2018
kristw pushed a commit to kristw/incubator-superset that referenced this pull request Sep 5, 2018
* bug: don't show query overlay when panning mapbox maps

Since we don't want to prompt user to rerun query every time they pan a map, prevent the query overlay from showing by setting dontRefreshOnChange for viewport_latitude and viewport_longitude controls.

* Prevent query overlay on viewport zoom also.

(cherry picked from commit a411516)
mistercrunch pushed a commit to lyft/incubator-superset that referenced this pull request Sep 21, 2018
* bug: don't show query overlay when panning mapbox maps

Since we don't want to prompt user to rerun query every time they pan a map, prevent the query overlay from showing by setting dontRefreshOnChange for viewport_latitude and viewport_longitude controls.

* Prevent query overlay on viewport zoom also.

(cherry picked from commit a411516)
mistercrunch pushed a commit to lyft/incubator-superset that referenced this pull request Sep 21, 2018
* bug: don't show query overlay when panning mapbox maps

Since we don't want to prompt user to rerun query every time they pan a map, prevent the query overlay from showing by setting dontRefreshOnChange for viewport_latitude and viewport_longitude controls.

* Prevent query overlay on viewport zoom also.

(cherry picked from commit a411516)
mistercrunch pushed a commit to lyft/incubator-superset that referenced this pull request Sep 21, 2018
* bug: don't show query overlay when panning mapbox maps

Since we don't want to prompt user to rerun query every time they pan a map, prevent the query overlay from showing by setting dontRefreshOnChange for viewport_latitude and viewport_longitude controls.

* Prevent query overlay on viewport zoom also.

(cherry picked from commit a411516)
mistercrunch pushed a commit to lyft/incubator-superset that referenced this pull request Sep 21, 2018
* bug: don't show query overlay when panning mapbox maps

Since we don't want to prompt user to rerun query every time they pan a map, prevent the query overlay from showing by setting dontRefreshOnChange for viewport_latitude and viewport_longitude controls.

* Prevent query overlay on viewport zoom also.

(cherry picked from commit a411516)
mistercrunch pushed a commit to lyft/incubator-superset that referenced this pull request Sep 21, 2018
* bug: don't show query overlay when panning mapbox maps

Since we don't want to prompt user to rerun query every time they pan a map, prevent the query overlay from showing by setting dontRefreshOnChange for viewport_latitude and viewport_longitude controls.

* Prevent query overlay on viewport zoom also.

(cherry picked from commit a411516)
mistercrunch pushed a commit to lyft/incubator-superset that referenced this pull request Sep 21, 2018
* bug: don't show query overlay when panning mapbox maps

Since we don't want to prompt user to rerun query every time they pan a map, prevent the query overlay from showing by setting dontRefreshOnChange for viewport_latitude and viewport_longitude controls.

* Prevent query overlay on viewport zoom also.

(cherry picked from commit a411516)
mistercrunch pushed a commit to lyft/incubator-superset that referenced this pull request Sep 21, 2018
* bug: don't show query overlay when panning mapbox maps

Since we don't want to prompt user to rerun query every time they pan a map, prevent the query overlay from showing by setting dontRefreshOnChange for viewport_latitude and viewport_longitude controls.

* Prevent query overlay on viewport zoom also.

(cherry picked from commit a411516)
mistercrunch pushed a commit to lyft/incubator-superset that referenced this pull request Sep 21, 2018
* bug: don't show query overlay when panning mapbox maps

Since we don't want to prompt user to rerun query every time they pan a map, prevent the query overlay from showing by setting dontRefreshOnChange for viewport_latitude and viewport_longitude controls.

* Prevent query overlay on viewport zoom also.

(cherry picked from commit a411516)
mistercrunch pushed a commit to lyft/incubator-superset that referenced this pull request Sep 21, 2018
* bug: don't show query overlay when panning mapbox maps

Since we don't want to prompt user to rerun query every time they pan a map, prevent the query overlay from showing by setting dontRefreshOnChange for viewport_latitude and viewport_longitude controls.

* Prevent query overlay on viewport zoom also.

(cherry picked from commit a411516)
mistercrunch pushed a commit to lyft/incubator-superset that referenced this pull request Sep 21, 2018
* bug: don't show query overlay when panning mapbox maps

Since we don't want to prompt user to rerun query every time they pan a map, prevent the query overlay from showing by setting dontRefreshOnChange for viewport_latitude and viewport_longitude controls.

* Prevent query overlay on viewport zoom also.

(cherry picked from commit a411516)
betodealmeida pushed a commit to lyft/incubator-superset that referenced this pull request Oct 11, 2018
* bug: don't show query overlay when panning mapbox maps

Since we don't want to prompt user to rerun query every time they pan a map, prevent the query overlay from showing by setting dontRefreshOnChange for viewport_latitude and viewport_longitude controls.

* Prevent query overlay on viewport zoom also.

(cherry picked from commit a411516)
betodealmeida pushed a commit to lyft/incubator-superset that referenced this pull request Oct 11, 2018
* bug: don't show query overlay when panning mapbox maps

Since we don't want to prompt user to rerun query every time they pan a map, prevent the query overlay from showing by setting dontRefreshOnChange for viewport_latitude and viewport_longitude controls.

* Prevent query overlay on viewport zoom also.

(cherry picked from commit a411516)
betodealmeida pushed a commit to lyft/incubator-superset that referenced this pull request Oct 11, 2018
* bug: don't show query overlay when panning mapbox maps

Since we don't want to prompt user to rerun query every time they pan a map, prevent the query overlay from showing by setting dontRefreshOnChange for viewport_latitude and viewport_longitude controls.

* Prevent query overlay on viewport zoom also.

(cherry picked from commit a411516)
betodealmeida pushed a commit to lyft/incubator-superset that referenced this pull request Oct 12, 2018
* bug: don't show query overlay when panning mapbox maps

Since we don't want to prompt user to rerun query every time they pan a map, prevent the query overlay from showing by setting dontRefreshOnChange for viewport_latitude and viewport_longitude controls.

* Prevent query overlay on viewport zoom also.
betodealmeida pushed a commit to lyft/incubator-superset that referenced this pull request Oct 12, 2018
* bug: don't show query overlay when panning mapbox maps

Since we don't want to prompt user to rerun query every time they pan a map, prevent the query overlay from showing by setting dontRefreshOnChange for viewport_latitude and viewport_longitude controls.

* Prevent query overlay on viewport zoom also.

(cherry picked from commit a411516)
betodealmeida pushed a commit to lyft/incubator-superset that referenced this pull request Oct 12, 2018
* bug: don't show query overlay when panning mapbox maps

Since we don't want to prompt user to rerun query every time they pan a map, prevent the query overlay from showing by setting dontRefreshOnChange for viewport_latitude and viewport_longitude controls.

* Prevent query overlay on viewport zoom also.

(cherry picked from commit a411516)
youngyjd pushed a commit to lyft/incubator-superset that referenced this pull request Oct 17, 2018
* bug: don't show query overlay when panning mapbox maps

Since we don't want to prompt user to rerun query every time they pan a map, prevent the query overlay from showing by setting dontRefreshOnChange for viewport_latitude and viewport_longitude controls.

* Prevent query overlay on viewport zoom also.

(cherry picked from commit a411516)
youngyjd pushed a commit to lyft/incubator-superset that referenced this pull request Oct 17, 2018
* bug: don't show query overlay when panning mapbox maps

Since we don't want to prompt user to rerun query every time they pan a map, prevent the query overlay from showing by setting dontRefreshOnChange for viewport_latitude and viewport_longitude controls.

* Prevent query overlay on viewport zoom also.

(cherry picked from commit a411516)
youngyjd pushed a commit to lyft/incubator-superset that referenced this pull request Oct 17, 2018
* bug: don't show query overlay when panning mapbox maps

Since we don't want to prompt user to rerun query every time they pan a map, prevent the query overlay from showing by setting dontRefreshOnChange for viewport_latitude and viewport_longitude controls.

* Prevent query overlay on viewport zoom also.

(cherry picked from commit a411516)
youngyjd pushed a commit to lyft/incubator-superset that referenced this pull request Oct 17, 2018
* bug: don't show query overlay when panning mapbox maps

Since we don't want to prompt user to rerun query every time they pan a map, prevent the query overlay from showing by setting dontRefreshOnChange for viewport_latitude and viewport_longitude controls.

* Prevent query overlay on viewport zoom also.

(cherry picked from commit a411516)
youngyjd pushed a commit to lyft/incubator-superset that referenced this pull request Oct 17, 2018
* bug: don't show query overlay when panning mapbox maps

Since we don't want to prompt user to rerun query every time they pan a map, prevent the query overlay from showing by setting dontRefreshOnChange for viewport_latitude and viewport_longitude controls.

* Prevent query overlay on viewport zoom also.

(cherry picked from commit a411516)
mistercrunch pushed a commit to lyft/incubator-superset that referenced this pull request Oct 29, 2018
* bug: don't show query overlay when panning mapbox maps

Since we don't want to prompt user to rerun query every time they pan a map, prevent the query overlay from showing by setting dontRefreshOnChange for viewport_latitude and viewport_longitude controls.

* Prevent query overlay on viewport zoom also.

(cherry picked from commit a411516)
betodealmeida pushed a commit to lyft/incubator-superset that referenced this pull request Oct 30, 2018
* bug: don't show query overlay when panning mapbox maps

Since we don't want to prompt user to rerun query every time they pan a map, prevent the query overlay from showing by setting dontRefreshOnChange for viewport_latitude and viewport_longitude controls.

* Prevent query overlay on viewport zoom also.

(cherry picked from commit a411516)
betodealmeida pushed a commit to lyft/incubator-superset that referenced this pull request Oct 30, 2018
* bug: don't show query overlay when panning mapbox maps

Since we don't want to prompt user to rerun query every time they pan a map, prevent the query overlay from showing by setting dontRefreshOnChange for viewport_latitude and viewport_longitude controls.

* Prevent query overlay on viewport zoom also.

(cherry picked from commit a411516)
betodealmeida pushed a commit to lyft/incubator-superset that referenced this pull request Oct 30, 2018
* bug: don't show query overlay when panning mapbox maps

Since we don't want to prompt user to rerun query every time they pan a map, prevent the query overlay from showing by setting dontRefreshOnChange for viewport_latitude and viewport_longitude controls.

* Prevent query overlay on viewport zoom also.

(cherry picked from commit a411516)
betodealmeida pushed a commit to lyft/incubator-superset that referenced this pull request Oct 30, 2018
* bug: don't show query overlay when panning mapbox maps

Since we don't want to prompt user to rerun query every time they pan a map, prevent the query overlay from showing by setting dontRefreshOnChange for viewport_latitude and viewport_longitude controls.

* Prevent query overlay on viewport zoom also.

(cherry picked from commit a411516)
betodealmeida pushed a commit to lyft/incubator-superset that referenced this pull request Oct 30, 2018
* bug: don't show query overlay when panning mapbox maps

Since we don't want to prompt user to rerun query every time they pan a map, prevent the query overlay from showing by setting dontRefreshOnChange for viewport_latitude and viewport_longitude controls.

* Prevent query overlay on viewport zoom also.

(cherry picked from commit a411516)
youngyjd pushed a commit to lyft/incubator-superset that referenced this pull request Nov 2, 2018
* bug: don't show query overlay when panning mapbox maps

Since we don't want to prompt user to rerun query every time they pan a map, prevent the query overlay from showing by setting dontRefreshOnChange for viewport_latitude and viewport_longitude controls.

* Prevent query overlay on viewport zoom also.

(cherry picked from commit a411516)
youngyjd pushed a commit to lyft/incubator-superset that referenced this pull request Nov 2, 2018
* bug: don't show query overlay when panning mapbox maps

Since we don't want to prompt user to rerun query every time they pan a map, prevent the query overlay from showing by setting dontRefreshOnChange for viewport_latitude and viewport_longitude controls.

* Prevent query overlay on viewport zoom also.

(cherry picked from commit a411516)
wenchma pushed a commit to wenchma/incubator-superset that referenced this pull request Nov 16, 2018
* bug: don't show query overlay when panning mapbox maps

Since we don't want to prompt user to rerun query every time they pan a map, prevent the query overlay from showing by setting dontRefreshOnChange for viewport_latitude and viewport_longitude controls.

* Prevent query overlay on viewport zoom also.
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.28.0 labels Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.28.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants