Skip to content

Commit

Permalink
bug: don't show query overlay when panning mapbox maps (apache#5814)
Browse files Browse the repository at this point in the history
* bug: don't show query overlay when panning mapbox maps

Since we don't want to prompt user to rerun query every time they pan a map, prevent the query overlay from showing by setting dontRefreshOnChange for viewport_latitude and viewport_longitude controls.

* Prevent query overlay on viewport zoom also.

(cherry picked from commit a411516)
  • Loading branch information
xtinec authored and mistercrunch committed Sep 19, 2018
1 parent 8ae263c commit 99a1f7b
Showing 1 changed file with 6 additions and 0 deletions.
6 changes: 6 additions & 0 deletions superset/assets/src/explore/controls.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -1842,6 +1842,8 @@ export const controls = {
default: 11,
description: t('Zoom level of the map'),
places: 8,
// Viewport zoom shouldn't prompt user to re-run query
dontRefreshOnChange: true,
},

viewport_latitude: {
Expand All @@ -1852,6 +1854,8 @@ export const controls = {
isFloat: true,
description: t('Latitude of default viewport'),
places: 8,
// Viewport latitude changes shouldn't prompt user to re-run query
dontRefreshOnChange: true,
},

viewport_longitude: {
Expand All @@ -1862,6 +1866,8 @@ export const controls = {
isFloat: true,
description: t('Longitude of default viewport'),
places: 8,
// Viewport longitude changes shouldn't prompt user to re-run query
dontRefreshOnChange: true,
},

render_while_dragging: {
Expand Down

0 comments on commit 99a1f7b

Please sign in to comment.