feat: add header tooltip #7556
Merged
feat: add header tooltip #7556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
) * [WIP] Live query validation, where supported This builds on apache#7422 to build check-as-you-type sql query validation in Sql Lab. This closes apache#6707 too. It adds a (debounced) call to the validate_sql_json API endpoint with the querytext, and on Lyft infra is able to return feedback to the user (end to end) in $TBD seconds. At present feedback is provided only through the "annotations" mechanism build in to ACE, although I'd be open to adding full text elsewhere on the page if there's interest. * fix: Unbreak lints and tests
…#7517) This change makes the query progress bar only show whole number percentage changes, instead of numbers like 12.13168276%.
* Validate start/end when scheduling queries * Use chrono instead of Sugar
* Show scheduled queries * Remove column * Secure views * Add import * Fix unit tests * Reuse existing db connection from view * Remove unnecessary import
Codecov Report
@@ Coverage Diff @@
## master #7556 +/- ##
======================================
Coverage 65.2% 65.2%
======================================
Files 433 433
Lines 21433 21433
Branches 2360 2360
======================================
Hits 13975 13975
Misses 7338 7338
Partials 120 120
Continue to review full report at Codecov.
|
xtinec
approved these changes
May 20, 2019
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CATEGORY
Choose one
SUMMARY
Merge 7531 into master.
Long header titles are elided. To help users see the full header title, tooltips have been added.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TEST PLAN
Tested manually
ADDITIONAL INFORMATION