chore: improve packaging, fix version issues #8157
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 2, 2019
Closed
mistercrunch
force-pushed
the
version_fix
branch
from
0c6482e
to
56fc1ce
Compare
* make package.json the single source of truth for version, and allow to be in the package, just not in static/ though * limit what is in `static/` by using symlinks only on needed folder (dist, images) * remove some images that were not used/referenced in the package * move images used in documentation only under `static/images/docs/` and remove from python package itself tarball size (running `python setup.py sdist --formats=gztar`): * before 87.313764 * after 56.373001
mistercrunch
force-pushed
the
version_fix
branch
from
56fc1ce
to
b4d8f14
Compare
mistercrunch
added a commit
to mistercrunch/superset
that referenced
this pull request
Sep 8, 2019
Ran into Cypress issues while getting too ambitious in apache#8157 this is a simplified more targeted version of it * include package.json (but not under static/) * use package.json as single source of truth for version info
|
Will reopen something similar, focussing on package size once #8196 is merged |
mistercrunch
added a commit
that referenced
this pull request
Sep 11, 2019
* Fix version info Ran into Cypress issues while getting too ambitious in #8157 this is a simplified more targeted version of it * include package.json (but not under static/) * use package.json as single source of truth for version info * typo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and allow to be in the package, just not in static/ though
static/by using symlinks only on needed folder(dist, images)
static/images/docs/and remove from python package itself
tarball size (running
python setup.py sdist --formats=gztar):87.31MB56.37MBCATEGORY
Choose one