Merge apache ee24539 #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add duration formatter * Remove sec and min formatters and add subMillisecond option
This reverts commit 7ac1a29.
…" (apache#8146) This reverts commit ed3360b.
) (apache#7929)" (apache#8147) This reverts commit 6df2a71.
Currently docker entrypoint is a bash script. `docker stop` command (or restart in kubernetes) sends SIGTERM to the container but it isn't catched by gunicorn. So gunicorn can't start graceful shutdown which may lead to killing user's connection and also adds 10s (default value) delay for stopping until docker sends SIGKILL. Using `exec` replaces the shell with the process being opened and signals are propagated correctly. Ref: https://docs.docker.com/engine/reference/commandline/stop/ Ref: https://unix.stackexchange.com/questions/146756/forward-sigterm-to-child-in-bash
Codecov Report
@@ Coverage Diff @@
## lyft-master #64 +/- ##
===============================================
- Coverage 73.14% 65.27% -7.88%
===============================================
Files 116 488 +372
Lines 12224 23436 +11212
Branches 0 2581 +2581
===============================================
+ Hits 8941 15297 +6356
- Misses 3283 7991 +4708
- Partials 0 148 +148
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## lyft-master #64 +/- ##
===============================================
- Coverage 73.14% 65.27% -7.88%
===============================================
Files 116 488 +372
Lines 12224 23436 +11212
Branches 0 2581 +2581
===============================================
+ Hits 8941 15297 +6356
- Misses 3283 7991 +4708
- Partials 0 148 +148
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that this still has the change from #63. We explicitly include the package.json file which differs from apache master. Max has a fix out in apache#8157 to help fix the build environment. Until this gets checked in, this is our work-around so we can deploy superset.