[Caching] Ensure cache is always created #9020
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
john-bodley
force-pushed
the
erik-ritter--always-create-cache
branch
from
302f3d2 to
1e18818
Compare
Codecov Report
@@ Coverage Diff @@
## master #9020 +/- ##
=======================================
Coverage 59.15% 59.15%
=======================================
Files 367 367
Lines 11686 11686
Branches 2866 2866
=======================================
Hits 6913 6913
Misses 4594 4594
Partials 179 179Continue to review full report at Codecov.
|
craig-rueda
reviewed
Jan 25, 2020
| # Accepts a custom cache initialization function, | ||
| # returning an object compatible with Flask-Caching API | ||
| return cache_config(app) | ||
| if isinstance(cache_config, dict): |
There was a problem hiding this comment.
Nice, this was confusing logic
craig-rueda
approved these changes
Jan 25, 2020
john-bodley
force-pushed
the
erik-ritter--always-create-cache
branch
from
1e18818 to
640dccb
Compare
john-bodley
reviewed
Jan 25, 2020
| @@ -571,10 +572,6 @@ class CeleryConfig: # pylint: disable=too-few-public-methods | |||
| SMTP_PASSWORD = "superset" | |||
| SMTP_MAIL_FROM = "superset@superset.com" | |||
|
|
|||
| if not CACHE_DEFAULT_TIMEOUT: | |||
There was a problem hiding this comment.
This logic is in the same block as line #313 and always evaluates to True and thus isn't required (hence the deletion).
dpgaspar
approved these changes
Jan 25, 2020
john-bodley
pushed a commit
to airbnb/superset-fork
that referenced
this pull request
Jan 26, 2020
* [Caching] Ensure cache is always created * Update cache_manager.py * Refactoring cache typing (cherry picked from commit 68e85ab)
6 tasks
9 tasks
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CATEGORY
Choose one
SUMMARY
Flask-Caching supports passing in
"null"as the cache type, which resolves to no caching at all (https://flask-caching.readthedocs.io/en/latest/#nullcache). This is preferred to setting the cache toNoneso that we can assume a cache is always initialized and calls tocache.memoize()will never fail.TEST PLAN
CI
ADDITIONAL INFORMATION
REVIEWERS
to: @john-bodley @craig-rueda @villebro @mistercrunch