Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propose cache type simple #9024

Closed
wants to merge 1 commit into from
Closed

Conversation

dpgaspar
Copy link
Member

CATEGORY

  • Bug Fix
  • Enhancement (new features, refinement)
  • Refactor
  • Add tests
  • Build / Development Environment
  • Documentation

SUMMARY

Seems like #9019 makes startup fail on a default configuration. Tests pass because they set cache to simple. We can revert/fix #9019 or change cache default to simple (assuming it's limitations): https://flask-caching.readthedocs.io/en/latest/#simplecache

Startup error:

class PrestoEngineSpec(BaseEngineSpec):
  File "/home/dpgaspar/workarea/preset/preset_fork_superset/superset/db_engine_specs/presto.py", line 950, in PrestoEngineSpec
    @cache.memoize()
  File "/home/dpgaspar/workarea/preset/v_superset/lib/python3.6/site-packages/werkzeug/local.py", line 348, in __getattr__
    return getattr(self._get_current_object(), name)
AttributeError: 'NoneType' object has no attribute 'memoize'

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

REVIEWERS

@dpgaspar
Copy link
Member Author

Closing, only saw #9020 now

@dpgaspar dpgaspar removed the request for review from etr2460 January 25, 2020 22:43
@dpgaspar dpgaspar closed this Jan 25, 2020
@codecov-io
Copy link

Codecov Report

Merging #9024 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #9024   +/-   ##
=======================================
  Coverage   59.15%   59.15%           
=======================================
  Files         367      367           
  Lines       11686    11686           
  Branches     2866     2866           
=======================================
  Hits         6913     6913           
  Misses       4594     4594           
  Partials      179      179

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c552c85...106ae7a. Read the comment docs.

@dpgaspar dpgaspar deleted the fix/cache-presto branch January 25, 2020 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants