[microTVM][ARM][Zephyr] Add CMSIS dependencies in Zephyr project build #11362
Conversation
mehrdadh
force-pushed
the
microtvm/fix_cmsis_dep
branch
from
6da51cb
to
8828561
Compare
mehrdadh
force-pushed
the
microtvm/fix_cmsis_dep
branch
from
6fe730c
to
e4035c5
Compare
| def _load_cmsis(self, lib_path: Union[str, pathlib.Path]): | ||
| """Copy CMSIS header files to generated project.""" | ||
|
|
||
| cmsis_path = pathlib.Path(os.environ["CMSIS_PATH"]) |
There was a problem hiding this comment.
why not make this a project option for now?
There was a problem hiding this comment.
I think that should be a project options that I missed. Done!
| @@ -455,6 +476,15 @@ def generate_project(self, model_library_format_path, standalone_crt_dir, projec | |||
| os.makedirs(extract_path) | |||
| tf.extractall(path=extract_path) | |||
|
|
|||
| # Add CMSIS libraries if required. | |||
| if options["project_type"] == "host_driven": | |||
There was a problem hiding this comment.
I changed it to support both and different module names.
| def _load_cmsis(self, lib_path: Union[str, pathlib.Path]): | ||
| """Copy CMSIS header files to generated project.""" | ||
|
|
||
| cmsis_path = pathlib.Path(os.environ["CMSIS_PATH"]) |
There was a problem hiding this comment.
I think that should be a project options that I missed. Done!
| @@ -455,6 +476,15 @@ def generate_project(self, model_library_format_path, standalone_crt_dir, projec | |||
| os.makedirs(extract_path) | |||
| tf.extractall(path=extract_path) | |||
|
|
|||
| # Add CMSIS libraries if required. | |||
| if options["project_type"] == "host_driven": | |||
There was a problem hiding this comment.
I changed it to support both and different module names.
disabled conv2d_nhwc_dsp.arm_cpu for non integers workloads added debugging feature to TempDirectory
mehrdadh
force-pushed
the
microtvm/fix_cmsis_dep
branch
from
f46fce9
to
b31a618
Compare
| @@ -70,6 +69,8 @@ | |||
|
|
|||
| ZEPHYR_BASE = os.getenv("ZEPHYR_BASE") | |||
|
|
|||
| CMSIS_PATH = os.getenv("CMSIS_PATH") | |||
There was a problem hiding this comment.
yeah, used it as default if project option is not passed
There was a problem hiding this comment.
i think it might be good to avoid hidden env variable dependencies. they can be hard to track down. what do you think?
There was a problem hiding this comment.
makes sense, I removed the default value.
| def pytest_configure(config): | ||
| config.addinivalue_line( | ||
| "markers", | ||
| "skip_by_board(board): skip test for the given board", |
There was a problem hiding this comment.
@mehrdadh does this need to be skip_boards?
"skip_boards(board): skip test for the given board",
This PR does the following:
cc @areusch @gromero