[Hexagon] Download generated artifacts from android device to host #11476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
supersat
reviewed
May 26, 2022
| def _copy_artifacts_to_host(self): | ||
| # Copy generated artifacts from device to host | ||
| if self._host_workspace: | ||
| for file in ["tvm_rpc_android.farf", "tvm_rpc_android.log"]: |
There was a problem hiding this comment.
The farf file only configures fastrpc to forward Hexagon logs to Android's logging facility. There's no need to pull it back off the device.
There was a problem hiding this comment.
If the intention is to pull of the debug output from Hexagon, you'll likely need to run logcat in parallel, possibly filtering out extraneous messages from the rest of the system.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
waiting for #11362 to merge.
cc @csullivan @farshidsp