Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ONNX] QGemm support #13747

Merged
merged 1 commit into from
Jan 26, 2023
Merged

[ONNX] QGemm support #13747

merged 1 commit into from
Jan 26, 2023

Conversation

chengven027
Copy link
Contributor

Hi, TVM
I try to add a new onnx operator QGEMM.
Please help to review,thanks. @AndrewZhaoLuo

@tvm-bot
Copy link
Collaborator

tvm-bot commented Jan 10, 2023

Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.

Generated by tvm-bot

python/tvm/relay/frontend/onnx.py Outdated Show resolved Hide resolved
python/tvm/relay/frontend/onnx.py Outdated Show resolved Hide resolved
python/tvm/relay/frontend/onnx.py Outdated Show resolved Hide resolved
@chengven027
Copy link
Contributor Author

Thanks for your review. I updated the comment. Please review again, Thanks. @KJlaccHoeUM9l

@AndrewZhaoLuo
Copy link
Contributor

@tvm-bot rerun

@AndrewZhaoLuo
Copy link
Contributor

Sorry, I will take a look tomorrow.


@classmethod
def _impl_v1(cls, inputs, attr, params):
# http://www.xavierdupre.fr/app/mlprodict/helpsphinx/onnxops/onnx_commicrosoft_QGemm.html
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you want to add a link to the documentation, it's better to point to the official documentation for ORT:
https://github.com/microsoft/onnxruntime/blob/main/docs/ContribOperators.md#com.microsoft.QGemm

Copy link
Contributor

@AndrewZhaoLuo AndrewZhaoLuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase to fix CI issues and point documentation to official repo.

Otherwise LGTM.

@chengven027
Copy link
Contributor Author

Done, Thanks,please review again. @AndrewZhaoLuo

@AndrewZhaoLuo AndrewZhaoLuo merged commit f7dfef4 into apache:main Jan 26, 2023
fzi-peccia pushed a commit to fzi-peccia/tvm that referenced this pull request Mar 27, 2023
Co-authored-by: cheng.wen <wen.cheng@intellif.com>
@chengven027 chengven027 deleted the add.onnx.QGemm branch January 12, 2024 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants