-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[topi] Add arm_cpu
specific pooling schedules
#14855
Conversation
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.
Generated by tvm-bot |
30ac191
to
41abde2
Compare
d62170b
to
b2b0b9a
Compare
b2b0b9a
to
2a8aac6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @FranklandJack, this looks very nice addition! I left some small comments and questions below
This commit: * Adds specialized `arm_cpu` pooling schedules for both fixed width and salable vectors. * Enables topi testing of new `arm_cpu` schedules.
2a8aac6
to
4a32938
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will leave open for a bit longer to give chance for any final comments
Thanks @lhutton1. This has been open for almost two months now, so hopefully everyone who it might affect has had a chance to see it. I haven't got write permissions, so feel free to merge when you think its ready. |
NOTE: this PR causes a regression in importing order:
|
This reverts commit 9f8fe3c.
Thanks @junrushao for the quick catch. I had a quick look into this but I wasn't able to reproduce the issue. Do you have a small script I could try out? |
This commit: * Adds specialized `arm_cpu` pooling schedules for both fixed width and salable vectors. * Enables topi testing of new `arm_cpu` schedules.
Revert "[topi] Add `arm_cpu` specific pooling schedules (apache#14855)" This reverts commit 9f8fe3c.
This commit: * Adds specialized `arm_cpu` pooling schedules for both fixed width and salable vectors. * Enables topi testing of new `arm_cpu` schedules.
Revert "[topi] Add `arm_cpu` specific pooling schedules (apache#14855)" This reverts commit 9f8fe3c.
This commit: * Adds specialized `arm_cpu` pooling schedules for both fixed width and salable vectors. * Enables topi testing of new `arm_cpu` schedules.
Revert "[topi] Add `arm_cpu` specific pooling schedules (apache#14855)" This reverts commit 9f8fe3c.
This commit:
arm_cpu
pooling schedules for both fixed width and salable vectors.arm_cpu
schedules.