Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[topi] Add arm_cpu specific pooling schedules" #15286

Merged
merged 1 commit into from
Jul 11, 2023

Conversation

junrushao
Copy link
Member

Reverts #14855

@tvm-bot
Copy link
Collaborator

tvm-bot commented Jul 10, 2023

Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.

  • No users to tag found in teams: topi See #10317 for details

Generated by tvm-bot

@junrushao
Copy link
Member Author

NOTE: #14855 introduces a bug in importing order:

Traceback (most recent call last):
  File "/root/Projects/tvm-dev/main.py", line 10, in <module>
    from tvm.testing import local_run
  File "/root/Projects/tvm-dev/python/tvm/testing/__init__.py", line 21, in <module>
    from . import auto_scheduler, autotvm
  File "/root/Projects/tvm-dev/python/tvm/testing/auto_scheduler.py", line 20, in <module>
    from tvm import auto_scheduler, te, topi
  File "/root/Projects/tvm-dev/python/tvm/topi/__init__.py", line 51, in <module>
    from . import nn
  File "/root/Projects/tvm-dev/python/tvm/topi/nn/__init__.py", line 35, in <module>
    from .conv3d_transpose import *
  File "/root/Projects/tvm-dev/python/tvm/topi/nn/conv3d_transpose.py", line 21, in <module>
    from tvm import relay
  File "/root/Projects/tvm-dev/python/tvm/relay/__init__.py", line 29, in <module>
    from . import prelude
  File "/root/Projects/tvm-dev/python/tvm/relay/prelude.py", line 21, in <module>
    from tvm.relay.transform import ToANormalFormExpr
  File "/root/Projects/tvm-dev/python/tvm/relay/transform/__init__.py", line 22, in <module>
    from . import fake_quantization_to_integer, mixed_precision
  File "/root/Projects/tvm-dev/python/tvm/relay/transform/fake_quantization_to_integer.py", line 25, in <module>
    from tvm.relay.qnn.op import canonicalizations
  File "/root/Projects/tvm-dev/python/tvm/relay/qnn/__init__.py", line 20, in <module>
    from . import op
  File "/root/Projects/tvm-dev/python/tvm/relay/qnn/op/__init__.py", line 21, in <module>
    from .qnn import *
  File "/root/Projects/tvm-dev/python/tvm/relay/qnn/op/qnn.py", line 26, in <module>
    from tvm.relay.op.nn.utils import get_pad_tuple2d
  File "/root/Projects/tvm-dev/python/tvm/relay/op/__init__.py", line 35, in <module>
    from . import strategy
  File "/root/Projects/tvm-dev/python/tvm/relay/op/strategy/__init__.py", line 24, in <module>
    from . import arm_cpu
  File "/root/Projects/tvm-dev/python/tvm/relay/op/strategy/arm_cpu.py", line 29, in <module>
    from ....topi.arm_cpu.mprofile import dsp
  File "/root/Projects/tvm-dev/python/tvm/topi/arm_cpu/__init__.py", line 33, in <module>
    from . import qnn_alter_op
  File "/root/Projects/tvm-dev/python/tvm/topi/arm_cpu/qnn_alter_op.py", line 25, in <module>
    from ..nn import qnn_conv2d_alter_layout, add_alter_layout, qnn_requantize_alter_layout
ImportError: cannot import name 'qnn_conv2d_alter_layout' from partially initialized module 'tvm.topi.nn' (most likely due to a circular import) (/root/Projects/tvm-dev/python/tvm/topi/nn/__init__.py)

This should be relatively easy to fix, but for now, to quickly unblock us from making progress, let's consider a temporary revert

@junrushao junrushao marked this pull request as ready for review July 11, 2023 00:44
@ekalda ekalda merged commit 81d7f79 into main Jul 11, 2023
@junrushao junrushao deleted the revert-14855-pool-2d-sched branch July 15, 2023 00:57
junrushao added a commit to junrushao/tvm that referenced this pull request Jul 24, 2023
Revert "[topi] Add `arm_cpu` specific pooling schedules (apache#14855)"

This reverts commit 9f8fe3c.
junrushao added a commit to junrushao/tvm that referenced this pull request Jul 27, 2023
Revert "[topi] Add `arm_cpu` specific pooling schedules (apache#14855)"

This reverts commit 9f8fe3c.
junrushao added a commit to junrushao/tvm that referenced this pull request Jul 30, 2023
Revert "[topi] Add `arm_cpu` specific pooling schedules (apache#14855)"

This reverts commit 9f8fe3c.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants