[YUNIKORN-2077] Cleanup scheduler event interface in shim (#704)

Closes: #704 Signed-off-by: Craig Condit <ccondit@apache.org>
apache · Oct 26, 2023 · 2eebc3a · 2eebc3a
1 parent 206f427
commit 2eebc3a
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 16 deletions.
diff --git a/pkg/cmd/shim/main.go b/pkg/cmd/shim/main.go
@@ -52,7 +52,7 @@ func main() {
 	if serviceContext.RMProxy != nil {
 		ss := shim.NewShimScheduler(serviceContext.RMProxy, conf.GetSchedulerConf(), configMaps)
 		if err := ss.Run(); err != nil {
-			log.Log(log.Shim).Fatal("Unable tto start scheduler", zap.Error(err))
+			log.Log(log.Shim).Fatal("Unable to start scheduler", zap.Error(err))
 		}
 
 		signalChan := make(chan os.Signal, 1)

diff --git a/pkg/common/events/events.go b/pkg/common/events/events.go
@@ -64,18 +64,6 @@ type TaskEvent interface {
 	GetArgs() []interface{}
 }
 
-// --------------------------------------
-// scheduler events
-// --------------------------------------
-type SchedulerEvent interface {
-	// the type of this event
-	GetEvent() string
-
-	// an event can have multiple arguments, these arguments will be passed to
-	// state machines' callbacks when doing state transition
-	GetArgs() []interface{}
-}
-
 // --------------------------------------
 // scheduler node events
 // --------------------------------------

diff --git a/pkg/dispatcher/dispatcher.go b/pkg/dispatcher/dispatcher.go
@@ -40,7 +40,6 @@ const (
 	EventTypeApp EventType = iota
 	EventTypeTask
 	EventTypeNode
-	EventTypeScheduler
 )
 
 var (
@@ -194,8 +193,6 @@ func Start() {
 					getEventHandler(EventTypeApp)(v)
 				case events.SchedulerNodeEvent:
 					getEventHandler(EventTypeNode)(v)
-				case events.SchedulerEvent:
-					getEventHandler(EventTypeScheduler)(v)
 				default:
 					log.Log(log.ShimDispatcher).Fatal("unsupported event",
 						zap.Any("event", v))