Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[YUNIKORN-2077] Cleanup scheduler event interface in shim #704

Closed
wants to merge 1 commit into from

Conversation

chenyulin0719
Copy link
Contributor

What is this PR for?

The scheduler state machine was removed from shim after YUNIKORN-2074, and the interface for creating scheduler event could be removed too.

  • SchedulerEvent (events.go)
  • EventTypeScheduler (dispatcher.go)

What type of PR is it?

  • - Bug Fix
  • - Improvement
  • - Feature
  • - Documentation
  • - Hot Fix
  • - Refactoring

Todos

  • - Task

What is the Jira issue?

https://issues.apache.org/jira/browse/YUNIKORN-2077

How should this be tested?

All existing e2e test should pass.

Screenshots (if appropriate)

NA

Questions:

NA

@codecov
Copy link

codecov bot commented Oct 26, 2023

Codecov Report

Merging #704 (64cb93d) into master (206f427) will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #704      +/-   ##
==========================================
+ Coverage   71.64%   71.65%   +0.01%     
==========================================
  Files          50       50              
  Lines        7955     7953       -2     
==========================================
  Hits         5699     5699              
+ Misses       2058     2056       -2     
  Partials      198      198              
Files Coverage Δ
pkg/dispatcher/dispatcher.go 78.41% <ø> (+1.11%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@craigcondit craigcondit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants