Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix build from source docs #1598

Merged
merged 3 commits into from
Apr 6, 2022
Merged

Fix build from source docs #1598

merged 3 commits into from
Apr 6, 2022

Conversation

thpani
Copy link
Collaborator

@thpani thpani commented Apr 6, 2022

Fix the instructions for building from source:

  • Correct the Scala version 12.0 -> 2.12.0
  • Re-introduce instructions to source the shell env (otherwise unit tests will fail)

@thpani thpani requested a review from konnov April 6, 2022 09:01
konnov
konnov approved these changes Apr 6, 2022
View reviewed changes
Copy link
Collaborator

@konnov konnov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I have noticed that the JDK version is terribly outdated

docs/src/apalache/installation/source.md Show resolved Hide resolved
@thpani thpani enabled auto-merge April 6, 2022 09:21
@thpani thpani merged commit 972ee72 into unstable Apr 6, 2022
@thpani thpani deleted the th/fix-docs-buildfromsource branch April 6, 2022 10:00
@thpani thpani mentioned this pull request Apr 6, 2022
Closed
@thpani thpani mentioned this pull request Apr 25, 2022
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@konnov konnov konnov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thpani @konnov