Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump JDK version (+ Scala version in docs) #1662

Merged
merged 9 commits into from
Apr 27, 2022
Merged

Bump JDK version (+ Scala version in docs) #1662

merged 9 commits into from
Apr 27, 2022

Conversation

thpani
Copy link
Collaborator

@thpani thpani commented Apr 25, 2022 •
edited
Loading

Closes #1600

As discussed in #1598 (comment), bump the recommended JDK version. Also, sync docs to our current Scala version.

In particular:

  • Scala is already 2.12.15 in build.sbt – this PR only syncs the docs.
  • Recommended Java is bumped to JDK17, which has LTS support until at least 2025.
    • Our currently recommended JDK8 reached GA in 2014 and already went through End of Public Updates.
    • AdoptOpenJDK moved to the Eclipse Foundation and is now called Eclipse Temurin, this is reflected in the docs.

I've been running Apalache under JDK17 since I joined, and it's working just fine.

  • bump version in docs
  • bump github workflows
  • update release notes

@thpani thpani changed the title Bump Scala and Java version in docs Bump JDK version (+ Scala version in docs) Apr 26, 2022
@codecov-commenter
Copy link

codecov-commenter commented Apr 26, 2022 •
edited
Loading

Codecov Report

Merging #1662 (040a3d7) into unstable (ad6dac6) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##           unstable    #1662      +/-   ##
============================================
- Coverage     75.36%   75.35%   -0.01%     
============================================
  Files           357      357              
  Lines         11522    11522              
  Branches        576      578       +2     
============================================
- Hits           8683     8682       -1     
- Misses         2839     2840       +1
Impacted Files Coverage Δ
...he/io/annotations/parser/CommentPreprocessor.scala 95.60% <0.00%> (-1.10%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad6dac6...040a3d7. Read the comment docs.

@thpani thpani requested a review from a team April 26, 2022 11:06
@thpani thpani marked this pull request as ready for review April 26, 2022 11:06
konnov
konnov approved these changes Apr 26, 2022
View reviewed changes
Copy link
Collaborator

@konnov konnov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thpani thpani requested a review from shonfeder April 26, 2022 12:20
shonfeder
shonfeder approved these changes Apr 26, 2022
View reviewed changes
Copy link
Contributor

@shonfeder shonfeder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thanks!

@thpani thpani enabled auto-merge (squash) April 26, 2022 13:13
@thpani thpani disabled auto-merge April 26, 2022 13:15
@thpani thpani requested a review from shonfeder April 26, 2022 13:49
@thpani
Copy link
Collaborator Author

thpani commented Apr 26, 2022

Forgot about flake.nix and the Dockerfile. @shonfeder PTAL

shonfeder
shonfeder approved these changes Apr 26, 2022
View reviewed changes
Copy link
Contributor

@shonfeder shonfeder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Would be nice to consolidate this configuration more so we don't have to change it all over the place. Moving to a more nixified approach may be the way forward for that... I'll think about it and consult with Gabriela.

Thanks for the update!

@thpani thpani enabled auto-merge (squash) April 27, 2022 07:20
@thpani thpani merged commit 04ee3fe into unstable Apr 27, 2022
@thpani thpani deleted the th/bump-scala-java branch April 27, 2022 08:23
This was referenced May 2, 2022
Closed
Merged
p-offtermatt pushed a commit that referenced this pull request May 10, 2022
@thpani @p-offtermatt
Bump JDK version (+ Scala version in docs) (#1662)
e10c3b3 
* Bump Scala and Java version in docs
* Bump JDK in github workflows, Dockerfile, Nix flake
* Update release notes
@thpani thpani mentioned this pull request Aug 10, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@konnov konnov konnov approved these changes

@shonfeder shonfeder shonfeder approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update Java and Scala dependencies in docs
4 participants
@thpani @codecov-commenter @konnov @shonfeder