Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ujson, upickle to 3.3.1 #2905

Closed

Conversation

scala-steward
Copy link
Contributor

@scala-steward scala-steward commented May 19, 2024

About this PR

πŸ“¦ Updates

from 3.2.0 to 3.3.1

πŸ“œ GitHub Release Notes - Release Notes - Version Diff

Usage

βœ… Please merge!

I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.

If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.

Configure Scala Steward for your repository with a .scala-steward.conf file.

Have a fantastic day writing Scala!

βš™ Adjust future updates

Add this to your .scala-steward.conf file to ignore future updates of this dependency:

updates.ignore = [ { groupId = "com.lihaoyi" } ]

Or, add this to slow down future updates of this dependency:

dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "com.lihaoyi" }
}]
labels: library-update, early-semver-minor, semver-spec-minor, version-scheme:semver-spec, commit-count:1

@konnov konnov enabled auto-merge August 19, 2024 12:13
Copy link
Collaborator

@konnov konnov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@konnov
Copy link
Collaborator

konnov commented Aug 21, 2024

I suspect that this is the place in the Quint deserializer where the new version of upickle breaks:

// By default, upickle uses the key `"$type"` to differentiate cases of a case
// class, but quint uses the key `"kind"` to encode the variant tag. This
// override forms a custom deserializer that is just like the default, except
// the value of "kind" is used to differentiate
override def tagName = "kind"

Here is the relevant update in upickle: com-lihaoyi/upickle#579

@bugarela would you like to investigate this one? I don't think it is urgent, but we probably should fix it sooner or later, as it will not go away.

@bugarela
Copy link
Collaborator

Hi @konnov! I'll put this on my list, I can take a shot at it at some point over the next couple of weeks.

@konnov
Copy link
Collaborator

konnov commented Sep 4, 2024

Close in favor of #2979

@konnov konnov closed this Sep 4, 2024
auto-merge was automatically disabled September 4, 2024 08:58

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants