Update upickle to 4.0.0 and remove unecessary customizations #2979
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bugarela
commented
Sep 3, 2024
Comment on lines
-392
to
-397
| // NOTE: Contrary to quint values, for quint types, source IDs are optional. | ||
| // This is because many types are inferred, and not derived from the soruce. | ||
| // | ||
| // We therefor default id to -1 in the following, because upickle handles | ||
| // optional values stupidly and if we specify `id` as `Option[Int]` it will | ||
| // require the value of the ID field to be a (possibly empty) singleton array. |
There was a problem hiding this comment.
Unrelated to the PR, this comment was just outdated (the thing it refers to no longer exists)
konnov
approved these changes
Sep 4, 2024
We have @lihaoyi to thank for that! Due to the new features in 4.0.0, we got rid of a lot of custom serialization 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello
This is a replacement for #2905
I've updated
upickleandujsonall the way to the most recent version (4.0.0), as that includes features for things we had to work around before. This way, I was able to remove all of the customizedrwvalues, asmacroRWworks for everything now (with the proper config updates).I've also added a couple of tests that helped me debug things, but no behavior was changed.
I checked that this version is compatible with all Quint's integration tests.
make fmt-fix(or had formatting run automatically on all files edited)./unreleased/for any new functionality