Passes reordered + keep (C)initPrime after InlinePass #327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kukovec
changed the title
|
Once this passes I can merge it into #308 and close that. |
konnov
approved these changes
Nov 11, 2020
| @@ -65,10 +65,17 @@ class InlinePassImpl @Inject()(val options: PassOptions, | |||
| // Remove the operators that are not needed, | |||
| // as some of them may contain higher-order operators that cannot be substituted | |||
| val relevantOperators = NormalizedNames.userOperatorNamesFromOptions(options).toSet | |||
There was a problem hiding this comment.
why don't you extend userOperatorNamesFromOptions with the operators for cinit, initPrime, etc.? These names should keep the relevant operators, so later passes would not remove them.
|
Hi @Kukovec! Just checking in here, as it looks like this PR might be nearly ready for merge, which would help unblock other WIP. LMT if there's anything I can do to help it along :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the order of passes, so
CoverAnalysisPasscomes before inlining.