Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] make manifests fails due to controller-gen panic on go 1.22 #7455

Closed
sophon-zt opened this issue May 29, 2024 · 2 comments · Fixed by #7456
Closed

[BUG] make manifests fails due to controller-gen panic on go 1.22 #7455

sophon-zt opened this issue May 29, 2024 · 2 comments · Fixed by #7456
Assignees
Labels
kind/bug Something isn't working
Milestone

Comments

@sophon-zt
Copy link
Contributor

$ go version
go version go1.22.2 darwin/arm64
$ make manifests
...

Installing controller-gen@v0.12.1...
Successfully installed
/Users/zhangtao/develop/infracreate/kubeblocks_develop/bin/controller-gen rbac:roleName=manager-role crd:generateEmbeddedObjectMeta=true webhook paths="./cmd/manager/...;./apis/...;./controllers/..." output:crd:artifacts:config=config/crd/bases
panic: runtime error: invalid memory address or nil pointer dereference [recovered]
        panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x2 addr=0x0 pc=0x100696d14]

goroutine 282 [running]:
go/types.(*Checker).handleBailout(0x14000fd4000, 0x14002d6bd18)
        /Users/zhangtao/go/pkg/mod/golang.org/toolchain@v0.0.1-go1.22.2.darwin-arm64/src/go/types/check.go:367 +0x9c
panic({0x1009713a0?, 0x100f13f10?})
        /Users/zhangtao/go/pkg/mod/golang.org/toolchain@v0.0.1-go1.22.2.darwin-arm64/src/runtime/panic.go:770 +0x124
go/types.(*StdSizes).Sizeof(0x0, {0x100a3bfd0, 0x100f1c6c0})
        /Users/zhangtao/go/pkg/mod/golang.org/toolchain@v0.0.1-go1.22.2.darwin-arm64/src/go/types/sizes.go:228 +0x314
go/types.(*Config).sizeof(...)
        /Users/zhangtao/go/pkg/mod/golang.org/toolchain@v0.0.1-go1.22.2.darwin-arm64/src/go/types/sizes.go:333
go/types.representableConst.func1({0x100a3bfd0?, 0x100f1c6c0?})
        /Users/zhangtao/go/pkg/mod/golang.org/toolchain@v0.0.1-go1.22.2.darwin-arm64/src/go/types/const.go:76 +0x9c
go/types.representableConst({0x100a42230, 0x100ee8800}, 0x14000fd4000, 0x100f1c6c0, 0x14002d6b468)
        /Users/zhangtao/go/pkg/mod/golang.org/toolchain@v0.0.1-go1.22.2.darwin-arm64/src/go/types/const.go:92 +0x138
go/types.(*Checker).representation(0x14000fd4000, 0x14003af6580, 0x100f1c6c0)
        /Users/zhangtao/go/pkg/mod/golang.org/toolchain@v0.0.1-go1.22.2.darwin-arm64/src/go/types/const.go:256 +0x68
go/types.(*Checker).implicitTypeAndValue(0x14000fd4000, 0x14003af6580, {0x100a3bff8, 0x14000252b60})
        /Users/zhangtao/go/pkg/mod/golang.org/toolchain@v0.0.1-go1.22.2.darwin-arm64/src/go/types/expr.go:375 +0x304
go/types.(*Checker).assignment(0x14000fd4000, 0x14003af6580, {0x100a3bff8, 0x14000252b60}, {0x1007af560, 0x14})
        /Users/zhangtao/go/pkg/mod/golang.org/toolchain@v0.0.1-go1.22.2.darwin-arm64/src/go/types/assignments.go:52 +0x23c
go/types.(*Checker).initConst(0x14000fd4000, 0x140037791a0, 0x14003af6580)
        /Users/zhangtao/go/pkg/mod/golang.org/toolchain@v0.0.1-go1.22.2.darwin-arm64/src/go/types/assignments.go:126 +0x274
go/types.(*Checker).constDecl(0x14000fd4000, 0x140037791a0, {0x100a3eba0, 0x140024b0980}, {0x100a3eba0, 0x140024b09a0}, 0x0)
        /Users/zhangtao/go/pkg/mod/golang.org/toolchain@v0.0.1-go1.22.2.darwin-arm64/src/go/types/decl.go:490 +0x250
go/types.(*Checker).objDecl(0x14000fd4000, {0x100a47380, 0x140037791a0}, 0x0)
        /Users/zhangtao/go/pkg/mod/golang.org/toolchain@v0.0.1-go1.22.2.darwin-arm64/src/go/types/decl.go:191 +0x84c
go/types.(*Checker).packageObjects(0x14000fd4000)
        /Users/zhangtao/go/pkg/mod/golang.org/toolchain@v0.0.1-go1.22.2.darwin-arm64/src/go/types/resolver.go:693 +0x468
go/types.(*Checker).checkFiles(0x14000fd4000, {0x140020ebb90, 0x5, 0x5})
        /Users/zhangtao/go/pkg/mod/golang.org/toolchain@v0.0.1-go1.22.2.darwin-arm64/src/go/types/check.go:408 +0x164
go/types.(*Checker).Files(...)
        /Users/zhangtao/go/pkg/mod/golang.org/toolchain@v0.0.1-go1.22.2.darwin-arm64/src/go/types/check.go:372
sigs.k8s.io/controller-tools/pkg/loader.(*loader).typeCheck(0x140002814a0, 0x14001465920)
        /Users/zhangtao/go/pkg/mod/sigs.k8s.io/controller-tools@v0.12.1/pkg/loader/loader.go:286 +0x2d8
sigs.k8s.io/controller-tools/pkg/loader.(*Package).NeedTypesInfo(0x14001465920)
        /Users/zhangtao/go/pkg/mod/sigs.k8s.io/controller-tools@v0.12.1/pkg/loader/loader.go:99 +0x44
sigs.k8s.io/controller-tools/pkg/loader.(*TypeChecker).check(0x14001907230, 0x14001465920)
        /Users/zhangtao/go/pkg/mod/sigs.k8s.io/controller-tools@v0.12.1/pkg/loader/refs.go:268 +0x304
sigs.k8s.io/controller-tools/pkg/loader.(*TypeChecker).check.func1(0x66?)
        /Users/zhangtao/go/pkg/mod/sigs.k8s.io/controller-tools@v0.12.1/pkg/loader/refs.go:262 +0x58
created by sigs.k8s.io/controller-tools/pkg/loader.(*TypeChecker).check in goroutine 123
        /Users/zhangtao/go/pkg/mod/sigs.k8s.io/controller-tools@v0.12.1/pkg/loader/refs.go:260 +0x230
make: *** [manifests] Error 2
@weicao
Copy link
Contributor

weicao commented May 29, 2024

I tried go 1.22.3, and make manifests succeeds.

$ go version
go version go1.22.3 darwin/arm64
$ make manifests
go generate -x ./pkg/testutil/k8s/mocks/...
...

Generating clientset for apps:v1alpha1 dataprotection:v1alpha1 extensions:v1alpha1 workloads:v1alpha1 storage:v1alpha1 apps:v1beta1 at github.com/apecloud/kubeblocks/pkg/client/clientset
Generating listers for apps:v1alpha1 dataprotection:v1alpha1 extensions:v1alpha1 workloads:v1alpha1 storage:v1alpha1 apps:v1beta1 at github.com/apecloud/kubeblocks/pkg/client/listers
Generating informers for apps:v1alpha1 dataprotection:v1alpha1 extensions:v1alpha1 workloads:v1alpha1 storage:v1alpha1 apps:v1beta1 at github.com/apecloud/kubeblocks/pkg/client/informers

@cjc7373
Copy link
Contributor

cjc7373 commented Jun 5, 2024

I have the same problem in go 1.22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants