fix: controller-gen panic on go 1.22 #7456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sophon-zt
requested review from
nayutah,
ldming,
heng4fun,
free6om,
wangyelei,
Y-Rookie and
weicao
as code owners
sophon-zt
force-pushed
the
bugfix/make-manifests-fails-due-to-controller-gen-panic-on-go-122-issue7455
branch
from
1af23c5
to
526d99e
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7456 +/- ##
==========================================
- Coverage 65.95% 65.93% -0.03%
==========================================
Files 342 342
Lines 42135 42135
==========================================
- Hits 27791 27781 -10
- Misses 11922 11931 +9
- Partials 2422 2423 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
weicao
approved these changes
Jun 11, 2024
nayutah
approved these changes
Jun 11, 2024
sophon-zt
force-pushed
the
bugfix/make-manifests-fails-due-to-controller-gen-panic-on-go-122-issue7455
branch
from
526d99e
to
2218469
Compare
|
/approve for test |
apecloud-bot
approved these changes
Jun 11, 2024
sophon-zt
deleted the
bugfix/make-manifests-fails-due-to-controller-gen-panic-on-go-122-issue7455
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
chore: update controller-tools to v0.14.0 (#7455)
related bug: kubernetes-sigs/controller-tools#880