Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the ability to add a value for a request header to the root span as an attribute #3543

Closed
BrynCooke opened this issue Aug 7, 2023 · 1 comment · Fixed by #4102
Closed

Add the ability to add a value for a request header to the root span as an attribute #3543

BrynCooke opened this issue Aug 7, 2023 · 1 comment · Fixed by #4102
Assignees
@bnjjj

Comments

@BrynCooke
Copy link
Contributor

BrynCooke commented Aug 7, 2023 •
edited
Loading

This needs to be folded into #3226

To implement us a tracing layer that modifies the span event before passing it on.
@BrynCooke BrynCooke mentioned this issue Aug 7, 2023
Closed
@BrynCooke
Copy link
Contributor Author

Related to #3226

@bnjjj bnjjj mentioned this issue Nov 10, 2023
Merged
6 tasks
Geal pushed a commit that referenced this issue Nov 29, 2023
@bnjjj
Add support for custom attributes for spans and logs (#4102)
3fa7c11 
Fixes #4096
Fixes #4086
Fixes #3543
Fixes #3537


---------

Signed-off-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com>
Co-authored-by: bryn <bryn@apollographql.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bnjjj bnjjj

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add support for custom attributes for spans and logs apollographql/router
2 participants
@BrynCooke @bnjjj