Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add DynAttribute functionality to spans and logs #4096

Closed
Tracked by #3226
BrynCooke opened this issue Oct 25, 2023 · 0 comments · Fixed by #4102
Closed
Tracked by #3226

Add DynAttribute functionality to spans and logs #4096

BrynCooke opened this issue Oct 25, 2023 · 0 comments · Fixed by #4102
Assignees
@bnjjj

Comments

@BrynCooke
Copy link
Contributor

BrynCooke commented Oct 25, 2023 •
edited
Loading

We need to be able to create spans and logs with custom attributes defined in yaml.

Acceptance criteria:

  • We can create a span with dynamic attributes that are output to tracing and logs.
  • We can create a log message with custom attributes that are output to tracing and logs.
@BrynCooke BrynCooke mentioned this issue Oct 25, 2023
Open
28 tasks
@bnjjj bnjjj mentioned this issue Oct 26, 2023
Merged
6 tasks
Geal pushed a commit that referenced this issue Nov 29, 2023
@bnjjj
Add support for custom attributes for spans and logs (#4102)
3fa7c11 
Fixes #4096
Fixes #4086
Fixes #3543
Fixes #3537


---------

Signed-off-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com>
Co-authored-by: bryn <bryn@apollographql.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bnjjj bnjjj

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add support for custom attributes for spans and logs apollographql/router
2 participants
@BrynCooke @bnjjj