Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

trailing period appended to apollo.router.config metric attribute names #4689

Closed
garypen opened this issue Feb 20, 2024 · 0 comments · Fixed by #4712
Closed

trailing period appended to apollo.router.config metric attribute names #4689

garypen opened this issue Feb 20, 2024 · 0 comments · Fixed by #4712
Assignees
@BrynCooke

Comments

@garypen
Copy link
Contributor

garypen commented Feb 20, 2024

We are seeing, for example, :

opt.mode.passthrough.

(note the trailing period)

when we would like to see:

opt.mode.passthrough
@BrynCooke BrynCooke self-assigned this Feb 22, 2024
BrynCooke pushed a commit that referenced this issue Feb 22, 2024
Fix trailing dot on internal router usage metric attributes
b81bf44 
Metric attributes had an extra trailing dot that was introduced in #4364.

This PR strips off the extra dot that was introduced.

Fixes #4689
@BrynCooke BrynCooke mentioned this issue Feb 22, 2024
Merged
6 tasks
BrynCooke added a commit that referenced this issue Feb 22, 2024
@BrynCooke
Fix trailing dot on internal router usage metric attributes (#4712)
23656ea 
Internal config metric attributes had an extra trailing dot that was
introduced in #4364.

This PR strips off the extra dot that was introduced.

Fixes #4689

<!-- start metadata -->
---

**Checklist**

Complete the checklist (and note appropriate exceptions) before the PR
is marked ready-for-review.

- [ ] Changes are compatible[^1]
- [ ] Documentation[^2] completed
- [ ] Performance impact assessed and acceptable
- Tests added and passing[^3]
    - [ ] Unit Tests
    - [ ] Integration Tests
    - [ ] Manual Tests

**Exceptions**

*Note any exceptions here*

**Notes**

[^1]: It may be appropriate to bring upcoming changes to the attention
of other (impacted) groups. Please endeavour to do this before seeking
PR approval. The mechanism for doing this will vary considerably, so use
your judgement as to how and when to do this.
[^2]: Configuration is an important part of many changes. Where
applicable please try to document configuration examples.
[^3]: Tick whichever testing boxes are applicable. If you are adding
Manual Tests, please document the manual testing (extensively) in the
Exceptions.

Co-authored-by: bryn <bryn@apollographql.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BrynCooke BrynCooke

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix trailing dot on internal router usage metric attributes apollographql/router
2 participants
@garypen @BrynCooke