Adds new metrics for some apollo specific env variables #4364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@BrynCooke, please consider creating a changeset entry in |
|
CI performance tests
|
Use the new metrics macros rather than the hash map to exercise more of the stack. As a bonus, the thread that was used to continuously update the gauges is gone. Fixes #4290
BrynCooke
force-pushed
the
bryn/env-observability
branch
from
4b769f6 to
a87b283
Compare
o0Ignition0o
approved these changes
Dec 13, 2023
| data.meter | ||
| .u64_observable_gauge(metric_name) | ||
| .with_callback(move |observer| { | ||
| observer.observe(value, &attributes); |
There was a problem hiding this comment.
it s a pity oserve doesn't take an iterator :(
added 2 commits
December 13, 2023 11:11
Add missing env variables.
6 tasks
BrynCooke
added a commit
that referenced
this pull request
Feb 22, 2024
Internal config metric attributes had an extra trailing dot that was introduced in #4364. This PR strips off the extra dot that was introduced. Fixes #4689 <!-- start metadata --> --- **Checklist** Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review. - [ ] Changes are compatible[^1] - [ ] Documentation[^2] completed - [ ] Performance impact assessed and acceptable - Tests added and passing[^3] - [ ] Unit Tests - [ ] Integration Tests - [ ] Manual Tests **Exceptions** *Note any exceptions here* **Notes** [^1]: It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this. [^2]: Configuration is an important part of many changes. Where applicable please try to document configuration examples. [^3]: Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions. Co-authored-by: bryn <bryn@apollographql.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds some metrics for some specific apollo env variables to show if they are set or not.
Uses the new metrics macros rather than the hash map to exercise more of the stack.
As a bonus, the thread that was used to continuously update the gauges is gone.
I had to make some changes to the asserting to allow asserting of all metrics rather than just specific ones hence all the snapshot changes. On the plus side they look better now.
Fixes #4290
Checklist
Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.
Exceptions
Note any exceptions here
Notes
Footnotes
It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this. ↩
Configuration is an important part of many changes. Where applicable please try to document configuration examples. ↩
Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions. ↩