Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avoid generating a default apollo configuration #3887

Closed
wants to merge 8 commits into from

Conversation

Geal
Copy link
Contributor

@Geal Geal commented Sep 22, 2023

in multiple places, we are generating a default apollo exporter configuration to fill span information. We have seen in previous issues that using this default implementation can cause issues

Description here

Fixes #issue_number


Checklist

Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.

  • Changes are compatible1
  • Documentation2 completed
  • Performance impact assessed and acceptable
  • Tests added and passing3
    • Unit Tests
    • Integration Tests
    • Manual Tests

Exceptions

Note any exceptions here

Notes

Footnotes

  1. It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this.

  2. Configuration is an important part of many changes. Where applicable please try to document configuration examples.

  3. Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions.

in multiple places, we are generating a default apollo exporter
configuration to fill span information. We have seen in previous issues
that using this default implementation can cause issues
@github-actions
Copy link
Contributor

@Geal, please consider creating a changeset entry in /.changesets/. These instructions describe the process and tooling.

@router-perf
Copy link

router-perf bot commented Sep 22, 2023

CI performance tests

  • events_big_cap_high_rate - Stress test for events with a lot of users, deduplication enabled and high rate event with a big queue capacity
  • events_without_dedup - Stress test for events with a lot of users and deduplication DISABLED
  • events - Stress test for events with a lot of users and deduplication ENABLED
  • large-request - Stress test with a 1 MB request payload
  • step - Basic stress test that steps up the number of users over time
  • xlarge-request - Stress test with 10 MB request payload
  • reload - Reload test over a long period of time at a constant rate of users
  • no-graphos - Basic stress test, no GraphOS.
  • xxlarge-request - Stress test with 100 MB request payload
  • step-jemalloc-tuning - Clone of the basic stress test for jemalloc tuning
  • const - Basic stress test that runs with a constant number of users

@Geal
Copy link
Contributor Author

Geal commented Sep 22, 2023

I got another interesting failure: fixed in 941768c

Snapshot file: apollo-router/tests/snapshots/tracing_tests__variables.snap
Snapshot: variables
Source: apollo-router/tests/tracing_tests.rs:94
──────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
Expression: get_spans()
──────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
-old snapshot
+new results
────────────┬─────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
   85    85 │                 "trace_id",
   86    86 │                 "[REDACTED]"
   87    87 │               ],
   88    88 │               [
   89       │-                "client.name",
   90       │-                ""
   91       │-              ],
   92       │-              [
   93       │-                "client.version",
   94       │-                ""
   95       │-              ],
   96       │-              [
   97    89 │                 "otel.kind",
   98    90 │                 "INTERNAL"
   99    91 │               ],
  100    92 │               [
────────────┴─────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
To update snapshots run `cargo insta review`
Stopped on the first failure. Run `cargo insta test` to run all snapshots.
thread 'variables' panicked at 'snapshot assertion for 'variables' failed in line 94', /home/geal/.cargo/registry/src/index.crates.io-6f17d22bba15001f/insta-1.32.0/src/runtime.rs:563:9
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

this means that we're relying on something else than the apollo config's client name and client header to add them to the trace

@Geal Geal marked this pull request as ready for review September 25, 2023 13:00
@Geal Geal requested review from a team, SimonSapin, bnjjj and o0Ignition0o September 25, 2023 13:00
@Geal
Copy link
Contributor Author

Geal commented Oct 6, 2023

closing this since #3968 does most of the work here

@Geal Geal closed this Oct 6, 2023
@abernix abernix deleted the geal/avoid-default-apollo-config branch May 3, 2024 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants