Remove the use of Option in telemetry code #3968
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@BrynCooke, please consider creating a changeset entry in |
|
CI performance tests
|
BrynCooke
force-pushed
the
bryn/remove-telemetry-option
branch
from
31d9fe1 to
db8a3c2
Compare
…ig and related code. This significantly simplifies the codebase. Part of #3226
BrynCooke
force-pushed
the
bryn/remove-telemetry-option
branch
from
db8a3c2 to
594b593
Compare
BrynCooke
changed the title
Previously prom was enabled by default? In addition, there was no need to guard committing new prometheus as it is internally guarded.
BrynCooke
force-pushed
the
bryn/remove-telemetry-option
branch
from
08aa535 to
c001c5e
Compare
BrynCooke
force-pushed
the
bryn/remove-telemetry-option
branch
from
d001927 to
61b41cb
Compare
garypen
reviewed
Oct 6, 2023
| pub(crate) apollo_key: Option<String>, | ||
|
|
||
| /// The Apollo Studio graph reference. | ||
| #[schemars(skip)] | ||
| #[serde(skip)] | ||
| #[serde(default = "apollo_graph_reference")] | ||
| pub(crate) apollo_graph_ref: Option<String>, | ||
|
|
||
| /// The name of the header to extract from requests when populating 'client nane' for traces and metrics in Apollo Studio. | ||
| #[schemars(with = "Option<String>", default = "client_name_header_default_str")] |
There was a problem hiding this comment.
Is it still an Option in schemars? I find that odd anyway with a default, but that was already there I guess...
There was a problem hiding this comment.
It won't have been listed in schemars as it was previously serde skip. I think we should follow up with a way of passing in apollo_key and apollo_graph ref in plugin init rather than config.
garypen
approved these changes
Oct 6, 2023
This was referenced Oct 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed the use of Option in config and related consuming code. This significantly simplifies the codebase.
This isn't nearly as scary as it looks, as each code change is mostly just the removal of dealing with optional values.
Going forward we should use
Optionas a last resort in config structures, and instead prefer using defaults.Part of #3226
Checklist
Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.
Exceptions
Note any exceptions here
Notes
Footnotes
It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this. ↩
Configuration is an important part of many changes. Where applicable please try to document configuration examples. ↩
Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions. ↩