-
Notifications
You must be signed in to change notification settings - Fork 275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make changes to address new RUSTSEC details #6417
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RUSTSEC-2024-0421 identifies issues in the idna crate at versions < 1.0.3. We are not affected by the vulnerability, since the router is only using the crate to resolve subgraph addresses from a trusted source. We'll ignore the advisory. When we can update the hickory crate to a version using idna >=1.0.3, we'll remove the deny override. Additionally: Update the url crate to 2.5.4 anyway, so it's using idna 1.0.3
✅ Docs Preview ReadyNo new or changed pages found. |
@garypen, please consider creating a changeset entry in |
CI performance tests
|
bnjjj
approved these changes
Dec 9, 2024
I may have updated too much in the lock file, so try to recover it.
lrlna
approved these changes
Dec 9, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RUSTSEC-2024-0421 identifies issues in the idna crate at versions < 1.0.3.
We are not affected by the vulnerability, since the router is only using the crate to resolve subgraph addresses from a trusted source. We'll ignore the advisory.
When we can update the hickory crate to a version using idna >=1.0.3, we'll remove the deny override.
Additionally:
Update the url crate to 2.5.4 anyway, so it's using idna 1.0.3
Allow crates using UNICODE-3.0 license