Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix cargo about #6423

Merged
merged 4 commits into from
Dec 10, 2024
Merged

fix cargo about #6423

merged 4 commits into from
Dec 10, 2024

Conversation

bnjjj
Copy link
Contributor

@bnjjj bnjjj commented Dec 10, 2024 •
edited by garypen
Loading

cargo about and cargo deny have separate configuration files: about.toml and deny.toml.

deny.toml was updated to allow Unicode-3.0 license in #6417 , but about.toml was not updated. This is causing cargo xtask licenses to fail.

This PR fixes about.toml.

@bnjjj
fix cargo about
6c7aad8 
Signed-off-by: Benjamin <5719034+bnjjj@users.noreply.github.com>
@svc-apollo-docs
Copy link
Collaborator

svc-apollo-docs commented Dec 10, 2024 •
edited
Loading

✅ Docs Preview Ready

No new or changed pages found.

@github-actions GitHub Actions
Copy link
Contributor

@bnjjj, please consider creating a changeset entry in /.changesets/. These instructions describe the process and tooling.

@router-perf
Copy link

router-perf bot commented Dec 10, 2024

CI performance tests

  • connectors-const - Connectors stress test that runs with a constant number of users
  • const - Basic stress test that runs with a constant number of users
  • demand-control-instrumented - A copy of the step test, but with demand control monitoring and metrics enabled
  • demand-control-uninstrumented - A copy of the step test, but with demand control monitoring enabled
  • enhanced-signature - Enhanced signature enabled
  • events - Stress test for events with a lot of users and deduplication ENABLED
  • events_big_cap_high_rate - Stress test for events with a lot of users, deduplication enabled and high rate event with a big queue capacity
  • events_big_cap_high_rate_callback - Stress test for events with a lot of users, deduplication enabled and high rate event with a big queue capacity using callback mode
  • events_callback - Stress test for events with a lot of users and deduplication ENABLED in callback mode
  • events_without_dedup - Stress test for events with a lot of users and deduplication DISABLED
  • events_without_dedup_callback - Stress test for events with a lot of users and deduplication DISABLED using callback mode
  • extended-reference-mode - Extended reference mode enabled
  • large-request - Stress test with a 1 MB request payload
  • no-tracing - Basic stress test, no tracing
  • reload - Reload test over a long period of time at a constant rate of users
  • step-jemalloc-tuning - Clone of the basic stress test for jemalloc tuning
  • step-local-metrics - Field stats that are generated from the router rather than FTV1
  • step-with-prometheus - A copy of the step test with the Prometheus metrics exporter enabled
  • step - Basic stress test that steps up the number of users over time
  • xlarge-request - Stress test with 10 MB request payload
  • xxlarge-request - Stress test with 100 MB request payload

garypen
garypen requested changes Dec 10, 2024
View reviewed changes
Copy link
Contributor

@garypen garypen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bnjjj Please check out if my comment about aws-lc-sys is correct.

about.toml Outdated Show resolved Hide resolved
garypen and others added 3 commits December 10, 2024 12:09
@garypen
Try getting cargo-about to do the right thing in CI
85a6f9c 
 - remove the aws-lc-sys line. I think that's only required on
   hyper-upgrade branch
 - Force fetch of cargo-about using rust 1.83.0
@garypen
Fix the cargo-about install
1c586e9 
Remember to specify the toolchain version for cargo...
@bnjjj
fix cargo about
3527646 
Signed-off-by: Benjamin <5719034+bnjjj@users.noreply.github.com>
@garypen garypen self-requested a review December 10, 2024 13:29
garypen
garypen approved these changes Dec 10, 2024
View reviewed changes
Copy link
Contributor

@garypen garypen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has passed on nightly and looks good.

@bnjjj bnjjj enabled auto-merge (squash) December 10, 2024 13:32
@bnjjj bnjjj merged commit 5f72471 into dev Dec 10, 2024
13 checks passed
@bnjjj bnjjj deleted the bnjjj/fix_licenses_about branch December 10, 2024 13:53
bnjjj added a commit that referenced this pull request Dec 10, 2024
@bnjjj @garypen
fix cargo about (#6423)
e7efa7f 
Signed-off-by: Benjamin <5719034+bnjjj@users.noreply.github.com>
Co-authored-by: Gary Pennington <gary@apollographql.com>
bnjjj added a commit that referenced this pull request Dec 10, 2024
@bnjjj @garypen
fix cargo about (#6423)
d8c1fd4 
Signed-off-by: Benjamin <5719034+bnjjj@users.noreply.github.com>
Co-authored-by: Gary Pennington <gary@apollographql.com>
garypen pushed a commit that referenced this pull request Dec 10, 2024
@bnjjj @garypen
fix cargo about (#6423)
6a65579 
Signed-off-by: Benjamin <5719034+bnjjj@users.noreply.github.com>
Co-authored-by: Gary Pennington <gary@apollographql.com>
(cherry picked from commit 5f72471)
garypen added a commit that referenced this pull request Dec 10, 2024
@garypen
fix cargo about (#6423) (#6428)
926fe20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@garypen garypen garypen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bnjjj @svc-apollo-docs @garypen