Palette should be aware of apostrophe-workflow's workflowMode and hide the menu

[stuartromanek]

In a project level example of this we extended apostrophe-palette-widget's self.load method and attached req.session.workflowMode to the widget object.

[boutell]

Always check whether apos.modules['apostrophe-workflow'] exists so you can work well with or without it present.

…

On Fri, Sep 7, 2018 at 5:07 PM, Stuart Romanek ***@***.***> wrote: In a project level example of this we extended apostrophe-palette-widget's self.load method and attached req.session.workflowMode to the widget object. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#8>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAB9fTk9G290NLyVUHwSmHqRsQYi0YYsks5uYuAmgaJpZM4WferY> .

-- *THOMAS BOUTELL, CHIEF SOFTWARE ARCHITECT* P'UNK AVENUE | (215) 755-1330 | punkave.com

[ToshKoevoets]

Hi @boutell and @stuartromanek,

Not really sure how to implement stuart's solutions.

For now I've overwritten apostrophe's workflow admin bar implementation, but a cleaner, smaller solution is preferable imo. Maybe a notSafelist that can be overwritten. You guys have an idea for a better solution?

module.exports = {
  improve: 'apostrophe-admin-bar',
  construct: function(self, options) {
    // Hide most admin bar buttons in draft mode, specifically
    // those that manage pieces; you must be in draft mode to
    // do most things. Later perhaps we'll introduce a manage modal
    // for live mode that lets you preview things
    var superItemIsVisible = self.itemIsVisible;
    self.itemIsVisible = function(req, item) {
      var result = superItemIsVisible(req, item);

      if (!result) {
        return result;
      }

      if (req.locale && req.locale.match(/-draft$/)) {
        return result;
      }

      var notSafeLiveList = [ 'apostrophe-pages', 'apostrophe-tags', 'apostrophe-workflow-manage-modal', 'apostrophe-palette' ];
      if (_.contains(notSafeLiveList, item.name)) {
        return false;
      }

      // In addition, pieces manage buttons are not safe live
      // if the type is included in workflow; look
      // for subclasses
      var manager = self.apos.modules[item.name];
      if (!manager) {
        return result;
      }

      if (!(self.apos.synth.instanceOf(manager, 'apostrophe-pieces'))) {
        return result;
      }

      var workflow = self.apos.modules['apostrophe-workflow'];
      if (!workflow.includeType(manager.name)) {
        return result;
      }
      
      return false;
    };
  }
};

[boutell]

I'm not sure we're talking about the same thing. I think this ticket is just about hiding the palette UI when the workflowMode is not draft, as long as apostrophe-global is subject to workflow.

[stuartromanek]

Not sure of @ToshKoevoets 's path on this, however there should be a pattern around achieving this, yes @boutell ? Normal piece menus in the admin bar respect this mode without alteration.

[boutell]

I think it could be as simple as checking `data.global._edit` before showing the thing, unless that's already happening and it doesn't do the trick.

…

On Wed, Jul 8, 2020 at 10:17 AM Stuart Romanek ***@***.***> wrote: Not sure of @ToshKoevoets <https://github.com/ToshKoevoets> 's path on this, however there should be a pattern around achieving this, yes @boutell <https://github.com/boutell> ? Normal piece menus in the admin bar respect this mode without alteration. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#8 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAH27PXLCST4CND6EGS6V3R2R5XJANCNFSM4FT55LMA> .

-- THOMAS BOUTELL | CHIEF TECHNOLOGY OFFICER APOSTROPHECMS | apostrophecms.com | he/him/his

[stuartromanek]

@ToshKoevoets
Reviewing and working out how to make notSafeLiveList flexible, follow along at
apostrophecms/apostrophe-workflow#323
#26

[ToshKoevoets]

Hi @boutell and @stuartromanek,

Probably didn't fully understand this ticket, I assumed it was referring to the the fact that palette was displaying in main menu in Live /preview mode, but it seems I misunderstood.

@stuartromanek I saw the review and proposed changes. Thanks looks a lot better then my way!

Gr. Tosh