Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

external modules can add items to the list of menu items to hide when… #323

Merged
merged 5 commits into from
Jul 10, 2020

Conversation

stuartromanek
Copy link
Member

… in preview mode

anything to add here?

Copy link
Member

@boutell boutell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One thing, wouldn't die on the hill concerned

lib/modules/apostrophe-workflow-admin-bar/index.js Outdated Show resolved Hide resolved
Copy link
Member

@boutell boutell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"liveDenyList" is sufficient, "safeLiveDenyList" is unnecessary.

@stuartromanek
Copy link
Member Author

changed option name to removeWhenLive per internal discussion .. I also went ahead and softly concat'd the defaults and removed the need for a base .. does that feel alright @boutell ?

CHANGELOG.md Outdated
@@ -1,5 +1,8 @@
# Changelog

## 2.37.0
* Adds `options.baseSafeLiveDenyList` to `apostrophe-admin-bar`, a list of items to be removed from the admin bar during preview/live mode. It can be added to from other `apostrophe-admin-bar` improvers by including an array of apostrophe-module names in `options.safeLiveDenyList`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doc needs an update to match.

@stuartromanek stuartromanek merged commit dded22b into master Jul 10, 2020
@abea abea deleted the enhancement/contribute-to-notSafeLiveList branch July 15, 2020 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants