feat(web): include includeNullValues prop to handle sparse data
#1108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bietkul
suggested changes
Aug 21, 2019
| @@ -134,13 +139,13 @@ class RatingsFilter extends Component { | |||
| }, | |||
| }; | |||
| if (includeNullValues) { | |||
There was a problem hiding this comment.
I think we're already checking it in the util function.
bietkul
suggested changes
Aug 21, 2019
| @@ -129,23 +124,10 @@ class RatingsFilter extends Component { | |||
| static defaultQuery = (value, props, includeNullValues = false) => { | |||
There was a problem hiding this comment.
@ShahAnuj2610 Why includeNullValues is the third argument?
We can access it from props.
There was a problem hiding this comment.
no, the third argument comes from the includeUnrated in the data object
const handleUpdates = () => { this.updateQuery(value, props, includeUnrated); this.locked = false; if (props.onValueChange) props.onValueChange(value); }
There was a problem hiding this comment.
But why you named it includeNullValues?
bietkul
suggested changes
Aug 21, 2019
| @@ -129,23 +124,10 @@ class RatingsFilter extends Component { | |||
| static defaultQuery = (value, props, includeNullValues = false) => { | |||
There was a problem hiding this comment.
But why you named it includeNullValues?
|
@bietkul can rename |
bietkul
suggested changes
Aug 21, 2019
bietkul
approved these changes
Aug 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1059 #1096
includeNullValues