Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(web): add support for unrated results in RatingsFilter #1003

Merged
merged 5 commits into from
Jun 1, 2019

Conversation

ShahAnuj2610
Copy link
Contributor

@jyash97
Copy link
Contributor

jyash97 commented May 30, 2019

Hey, @ShahAnuj2610 Thanks for the PR.

Have you tested this by keeping URLParams as true ?

@ShahAnuj2610
Copy link
Contributor Author

ShahAnuj2610 commented May 30, 2019

Hey, @ShahAnuj2610 Thanks for the PR.

Have you tested this by keeping URLParams as true ?

@jyash97 fixed!

Copy link
Contributor

@jyash97 jyash97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ShahAnuj2610

The feature works well but there are some UI changes and testing needed while implementing this. Here are a few things that I noticed:

  1. When I don't have includeUnrated, I see an extra comma in the tab. Check this:
    image

  2. When we don't have includeUnrated the URL params just says true or null so either we should show includedUnrated or doesn't show. cc @siddharthlatest Thoughts?

  3. There is a proptype error coming on selectedValue

  4. We will also need to document these changes over here

@siddharthlatest
Copy link
Member

siddharthlatest commented May 31, 2019 via email

Copy link
Contributor

@jyash97 jyash97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ShahAnuj2610

These changes look good. Great Work! 💯

Thanks for Contribution 🥂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants