Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

web : Add includeUnrated in RatingsFilter #558

Closed
wants to merge 2 commits into from
Closed

web : Add includeUnrated in RatingsFilter #558

wants to merge 2 commits into from

Conversation

jyash97
Copy link
Contributor

@jyash97 jyash97 commented Oct 5, 2018

#267

Getting a prop-type error in SelectedValue, rest everything is working 💯

@davidklebanoff
Copy link

Does this cover both possible cases, when the rating is undefined or 0?

@jyash97
Copy link
Contributor Author

jyash97 commented Oct 8, 2018

The query is searching for rating which would be in the specified range and have no ratings associated to the document i.e. no rating key in the document object.

rating:0 can be specified in the data object

@davidklebanoff
Copy link

rating:0 can be specified in the data object

Good point!

metagrover
metagrover suggested changes Oct 17, 2018
View reviewed changes
Copy link
Contributor

@metagrover metagrover left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pointed out a minor issue. Besides that, quick question - how are we handling this in case the URLParams is true?

Does the includeUnrated get set in the URL/selectedValue (or) do we read it from the props based on the selected key?

Have you verified it in case of reloads and SSR?

packages/web/src/components/range/RatingsFilter.js
should: [
rangeQuery,
mustNotQuery,
],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add minimum_should_match: 1 here.

@jyash97
Copy link
Contributor Author

jyash97 commented Oct 18, 2018 •
edited
Loading

It is getting set on URL as : http://localhost:8001/?RatingsSensor=%5B3%2C5%2Ctrue%5D

true is the value passed to includeUnrated.
It is applying on reloading the URL when URLParams is true

@bietkul
Copy link
Contributor

bietkul commented Jun 3, 2019

@jyash97 Can we close it now?
I think it has been done here #1003

@jyash97
Copy link
Contributor Author

jyash97 commented Jun 3, 2019

Yeah this can be closed this was meant for v2. Already fixed in #1003

@jyash97 jyash97 closed this Jun 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@metagrover metagrover metagrover requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jyash97 @davidklebanoff @bietkul @metagrover