Add two fingers tap support #170
Conversation
lib/commands/gesture.js
Outdated
| @@ -27,6 +27,8 @@ commands.performTouch = async function (gestures) { | |||
| return await this.handleTap(gestures[0]); | |||
| } else if (gestures.length === 1 && gestures[0].action === 'doubleTap') { | |||
| return await this.handleDoubleTap(gestures[0]); | |||
| } else if (gestures.length === 1 && gestures[0].action === 'twoFingerTap') { | |||
There was a problem hiding this comment.
This does not exist as a thing in any of the clients.
Two finger tap would be a particular version of multi touch, so needs to be decoded within performMultiAction.
WebDriverAgent
Outdated
| @@ -1 +1 @@ | |||
| Subproject commit 6813e2549b684379e1b6a6ee96deb2b42f4e1a85 | |||
| Subproject commit a4c4f7ed24bb54a67d29719a57d397a5c90571af | |||
There was a problem hiding this comment.
Please don't update WDA like this. We update it in separate PRs so it is not buried.
…iver into add_two_fingers_tap_support
sergey-plevako-badoo
force-pushed
the
add_two_fingers_tap_support
branch
from
bc5e1b1 to
c80e61d
Compare
…iver into add_two_fingers_tap_support
|
|
|
This looks good to go! Thank you! Two things:
|
|
@sergey-plevako-badoo mind rebasing? looks like there's a conflict now |
sergey-plevako-badoo
force-pushed
the
add_two_fingers_tap_support
branch
from
c3fa1f9 to
8924801
Compare
…ey-plevako-badoo/appium-xcuitest-driver into add_two_fingers_tap_support
…ey-plevako-badoo/appium-xcuitest-driver into add_two_fingers_tap_support
…ey-plevako-badoo/appium-xcuitest-driver into add_two_fingers_tap_support
sergey-plevako-badoo
force-pushed
the
add_two_fingers_tap_support
branch
from
16641c3 to
fc87872
Compare
| @@ -79,6 +82,13 @@ function isDoubleTap (gestures) { | |||
| return false; | |||
| } | |||
|
|
|||
| function isTwoFingerTap (gestures) { | |||
| if (gestures.length === 1 && gestures[0].action.toLowerCase() === 'twofingertap') { | |||
There was a problem hiding this comment.
Hi @sergey-plevako-badoo! Is twofingertap in the W3C gesture spec? I don't remember it being there.
If not, we can't just add new actions. I like this change in general but I think this function probably needs to be rewritten to actually detect a 2-digit tap based on the number of digits in the action chain, rather than creating a new action type.
I'm not up on the spec these days though so maybe I can be convinced otherwise. @imurchie should probably also comment.
There was a problem hiding this comment.
just saw some more changes come through here. @imurchie have you taken a look?
There was a problem hiding this comment.
Technically nothing of this is in the W3C spec, so we could add it. Otherwise it could be mapped from a two tap gestures in the multi-action api.
There was a problem hiding this comment.
You're right, however given that when we do migrate to the new W3C spec, and it doesn't seem to have a "double-tap" primitive, probably better to do it the way that will be more easy to map to the spec later.
|
@sergey-plevako-badoo still waiting to hear back from you on the "twofingertap" + spec issue. |
|
Closing this PR as already implemented |
Add two fingers tap support from WDA