Make all XCTest gestures available for "mobile:" interface #393
Conversation
|
@sergey-plevako-badoo this is not exactly what you wanted to implement in #170, but should work as well. |
mykola-mokhnach
changed the title
lib/commands/gesture.js
Outdated
| scale: parseFloatParameter('scale', opts.scale, 'pinch'), | ||
| velocity: parseFloatParameter('velocity', opts.velocity, 'pinch') | ||
| }; | ||
| const el = opts.element.ELEMENT ? opts.element.ELEMENT : opts.element; |
There was a problem hiding this comment.
this pattern can be more succinctly written as:
const el = opts.element.ELEMENT || opts.element;
mykola-mokhnach
force-pushed
the
gestures
branch
2 times, most recently
from
a739b24 to
4753d3a
Compare
|
Fixed review comments and squashed the stuff |
lib/commands/execute.js
Outdated
| } | ||
| await mobileCommandsMapping[mobileCommand](opts); |
There was a problem hiding this comment.
wonder whether this actually needs to be return await in order to ensure that if WDA has any kind of return value it is passed back to the client?
There was a problem hiding this comment.
I know the current behavior also doesn't have return but it seems like that could be missing. however none of the proxy commands have return so we'd have to make this change everywhere if we cared about it.
There was a problem hiding this comment.
piece of cake :)
Added return
lib/commands/gesture.js
Outdated
| velocity: parseFloatParameter('velocity', opts.velocity, 'pinch') | ||
| }; | ||
| const el = opts.element.ELEMENT || opts.element; | ||
| await this.proxyCommand(`/wda/element/${el}/pinch`, 'POST', params); |
There was a problem hiding this comment.
awesome, however what i was subsequently reflecting on is that we'd need to have a return here, and in each other instance of proxyCommand inside a mobile method as well, if we want the outer return you just added to mean anything :-)
There was a problem hiding this comment.
still simple ;)
|
Thanks for the good words. Just trying not only to take but also to share something to the community. |
|
That's the spirit! 🙇 May we find some way to cultivate more contributors like you :-) |
mykola-mokhnach
force-pushed
the
gestures
branch
from
c2cf01d to
9d4732f
Compare
|
Looks good! |
This PR makes all XCTest gestures available for calling via mobile: interface, so one can use them even without specialised wrappers in top-level drivers. This is just a POC, so I didn't create any tests yet. Please kindly check the basic implementation first.