Removed findelement by nsPredicate string #394
Conversation
| @@ -228,6 +228,14 @@ private static CommandInfo deleteC(String url) { | |||
| return super.findElementsById(id); | |||
| } | |||
|
|
|||
| @Override public T findElement(String by, String using) { | |||
There was a problem hiding this comment.
It is not necessary to add @OverRide public T findElement(String by, String using)
but it is neccessary to override public List findElements(String by, String using) with T
There was a problem hiding this comment.
I'm on it.Will close this and styling issues ASAP.
|
@SrinivasanTarget, what do you mean by 'XCUIT mode will work'? Currently appium-xcuitest-driver does work with when used in conjunction with the nspredicate changes in the java-client. |
|
@Rafael-Chavez We accept nspredicate work but other UIAutomation methods won't work now on xcuitest-driver as per current status/architecure of java-client repo.So as you are aware iOSDriver is going to be split into IOSXCUITDriver and IOSAutomationDriver soon.Once this work is done, we will get this back to repo again with same authorship. #352 will be in again once driver split up is done. |
|
Great. Looking forward to the Split up driver work. Thanks @SrinivasanTarget |
|
Thanks for your support @Rafael-Chavez . Split up will happen soon in upcoming PR's. |
|
@TikhomirovSergey Have fixed the remarks |
| @@ -224,6 +224,10 @@ private static CommandInfo deleteC(String url) { | |||
| return super.findElements(by); | |||
| } | |||
|
|
|||
| @Override public List findElements(String by, String using) { | |||
There was a problem hiding this comment.
@SrinivasanTarget
You forgot to change this string to
@Override public List<T> findElements(String by, String using)
|
Everything is ok. But there is the remark above. |
Override findelements method in AppiumDriver fixed code styling issues minor corrections
Change list
1)Removed findelement by nsPredicate string
2)findelement and findelements methods of RemoteWebdriver is now public
Types of changes
What types of changes are you proposing/introducing to Java client?
Put an
xin the boxes that applyDetails
1)Removed findelement by nsPredicate string
@Rafael-Chavez Apologies for removing this now.#352 When XCUIT mode will work then we will commit these changes again with same authorship(rafael-chavez).
2)findelement and findelements methods of RemoteWebdriver is now public
Above methods are made public so that consumers of JSONWP in other projects can utilise this easily.
As we discussed earlier, IOSDriver will be split into IOSAutomationDriver and IOSXCUITDriver in upcoming PR's soon.
@TikhomirovSergey @Rafael-Chavez Please review.