Predicate locator added in IOSDriver, IOSElement, and iOSFindBy

[mt1729]

Types of changes

Added support for the existing FindsByIosNSPredicate interface to the classes above and in PageFactory strategies. Tests for each were updated to reflect changes

What types of changes are you proposing/introducing to Java client?
Put an x in the boxes that apply

• Bugfix (non-breaking change which fixes an issue)
• [ x] New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)

[SrinivasanTarget]

https://github.com/appium/java-client/pull/475/files#diff-2fe175c53bb11f987c6da9bb5fedc74eR46 CheckStyle will fail here.

[mt1729]

Oops, must have snuck in there. Fixed

[SrinivasanTarget]

I don't have iOS 9 devices with me to test. @TikhomirovSergey ping

[TikhomirovSergey]

@SrinivasanTarget @mt1729
It looks ok generally. But I need for some claryfication.
Does it work with the common IOSDriver starting? Don't you need some specific automation type?

[mt1729]

@TikhomirovSergey I don't believe the common driver has been updated yet to support finding elements directly by predicate, so this seems to be specific to the new XCUITest driver.

However, do you think it would be reasonable to use the UI Automation predicate helpers when finding by predicate using the common driver?

[SrinivasanTarget]

@mt1729 Yup Initially i was confused. Btw Are you able to get this working in XCUITest? If so can you please share your execution logs which succeed. I was not able to use this locator in XCUITest as well.

[mt1729]

@SrinivasanTarget Made a small mistake in the tests. The property should have been 'label' instead of 'name' which I've updated. Here are the logs for one of the tests running on my machine.

Let me know if this fix still doesn't work for you.

[SrinivasanTarget]

@mt1729 Got it. But it will fail on legacy driver.This should probably get in post #398

[rafe-g]

@SrinivasanTarget is this not the exact same thing that was removed here?
#394

Seems like you can just revert that commit.

FYI @TikhomirovSergey

[rafe-g]

Ping @SrinivasanTarget

[SrinivasanTarget]

@Rafael-Chavez Yup will look into it soon. Please sign here: #523

[TikhomirovSergey]

Sorry for the late responce. I'm closing this PR in favor #545