Fix hashing issues for messages/groups in arrays. #755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The original code here landed in f997206, but because of SR-7993 and not having yet landed a Package.swift that enabled 4.2 support, we weren't hitting this code yet. Since the visitor api uses Message, it doesn't know they messages are Hashable, the maps work because they get more complete type info to pick up the conformance declared on the Base used by for generated messages. So... Going back to manually mixing in the for Arrays, adding a Todo to revisit this. But this gets master back to working if someone tries to pull the code into a compiling context that is 4.2+.
|
I plan on revisiting this with |
allevato
approved these changes
Jun 14, 2018
ahmed-osama-saad
pushed a commit
to ahmed-osama-saad/swift-protobuf
that referenced
this pull request
Oct 12, 2023
Co-authored-by: RutgerVromans <rutger.vromans@signify.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original code here landed in f997206,
but because of SR-7993 and not having yet landed a Package.swift that
enabled 4.2 support, we weren't hitting this code yet.
Since the visitor api uses Message, it doesn't know they messages are
Hashable, the maps work because they get more complete type info to
pick up the conformance declared on the Base used by for generated
messages.
So...
Going back to manually mixing in the for Arrays, adding a Todo
to revisit this. But this gets master back to working if someone
tries to pull the code into a compiling context that is 4.2+.