Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hashing issues for messages/groups in arrays. #755

Merged
merged 1 commit into from
Jun 14, 2018
Merged

Fix hashing issues for messages/groups in arrays. #755

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 10 additions & 14 deletions Sources/SwiftProtobuf/HashVisitor.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -266,24 +266,20 @@ internal struct HashVisitor: Visitor {

mutating func visitRepeatedMessageField<M: Message>(value: [M], fieldNumber: Int) throws {
mix(fieldNumber)
#if swift(>=4.2)
mix(value.hashValue)
#else
for v in value {
mix(v.hashValue)
}
#endif
// TODO: Message doesn't add Hashable, _MessageImplementationBase does, so
// this can't use value.hashValue here, need to revisit this.
for v in value {
mix(v.hashValue)
}
}

mutating func visitRepeatedGroupField<G: Message>(value: [G], fieldNumber: Int) throws {
mix(fieldNumber)
#if swift(>=4.2)
mix(value.hashValue)
#else
for v in value {
mix(v.hashValue)
}
#endif
// TODO: Message doesn't add Hashable, _MessageImplementationBase does, so
// this can't use value.hashValue here, need to revisit this.
for v in value {
mix(v.hashValue)
}
}

mutating func visitMapField<KeyType, ValueType: MapValueType>(
Expand Down