Improve APNs http2 connection health check #568
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From Best Practices for Managing Connections,
And I happened when gorush try to send push to APNs, But cached http/2
connection is not available.Therefore I thik it is good that gorush
check APN/2 connection availability by HTTP/2 PING frame.
Here is a test code in local. With environment variable
GODEBUG=http2debug=2
, you can see a ping/2 log.Ping log looks like below: