Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Gorush container image #571

Merged
merged 2 commits into from
May 6, 2021
Merged

Update Gorush container image #571

merged 2 commits into from
May 6, 2021

Conversation

yokotaso
Copy link
Contributor

@yokotaso yokotaso commented May 5, 2021

Update gorush image which is patch build version.

Patch PR: appleboy/gorush#568, cybozu/gorush#1

@yokotaso yokotaso force-pushed the gorush-http2-ping-patch branch from f25f35b to d2efae7 Compare May 5, 2021 22:59
gorush/Dockerfile Show resolved Hide resolved
gorush/TAG Show resolved Hide resolved
@@ -3,10 +3,10 @@
# Stage1: build from source
FROM quay.io/cybozu/golang:1.15-bionic AS build

ARG GORUSH_VERSION="1.12.0"
ARG GORUSH_VERSION="1.13.0.3"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this is your fork and is a tentative release.
Why don't you tag it as 1.13.0.cybozu.1 or likewise?

Copy link
Member

@ymmt2005 ymmt2005 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yokotaso yokotaso merged commit e596a63 into main May 6, 2021
@yokotaso yokotaso deleted the gorush-http2-ping-patch branch May 6, 2021 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants