Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature]: Responsive Section in UQI #34319

Closed
Tracked by #34663
hetunandu opened this issue Jun 19, 2024 · 0 comments · Fixed by #35309
Closed
Tracked by #34663

[Feature]: Responsive Section in UQI #34319

hetunandu opened this issue Jun 19, 2024 · 0 comments · Fixed by #35309
Assignees
@albinAppsmith
Labels
Enhancement New feature or request IDE Navigation Issues/feature requests related to IDE navigation, and context switching IDE Pod Issues that new developers face while exploring the IDE IDE Product Issues related to the IDE Product potential-duplicate This label marks issues that are potential duplicates of already open issues QA Pod Issues under the QA Pod QA Needs QA attention

Comments

@hetunandu
Copy link
Member

hetunandu commented Jun 19, 2024 •
edited by albinAppsmith
Loading

Create a new control type called "Responsive Section"

Find all the rules here: Appsmith IDE

Response Section

  • Needs Y margin of 20px
  • Gap of 12 px
  • Defines max width of 800px
  • Can have any number of zones inside them
@hetunandu hetunandu added Enhancement New feature or request IDE Product Issues related to the IDE Product IDE Navigation Issues/feature requests related to IDE navigation, and context switching IDE Pod IDE Pod Issues that new developers face while exploring the IDE labels Jun 19, 2024
@github-actions github-actions bot removed the IDE Pod label Jun 19, 2024
@github-actions github-actions bot added the potential-duplicate This label marks issues that are potential duplicates of already open issues label Jul 3, 2024
This was referenced Jul 3, 2024
Closed
Open
@hetunandu hetunandu assigned hetunandu and albinAppsmith and unassigned hetunandu Jul 3, 2024
@appsmithorg appsmithorg deleted a comment from github-actions bot Jul 26, 2024
@albinAppsmith albinAppsmith mentioned this issue Jul 31, 2024
Merged
2 tasks
albinAppsmith added a commit that referenced this issue Aug 1, 2024
@albinAppsmith
feat: Added section component for action forms (#35309)
ccedf2e 
## Description

This PR added section component that can be used in UQI forms

Fixes #34319

## Automation

/ok-to-test tags="@tag.Sanity"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/10176993550>
> Commit: 95175f3
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10176993550&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Sanity`
> Spec:
> <hr>Wed, 31 Jul 2024 09:09:55 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [x] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **New Features**
- Introduced a modular `Section` component for improved UI structure and
reusability.
- Added responsive styling for the `Section` component, enhancing visual
consistency across the application.
- Enhanced accessibility by allowing other modules to easily integrate
the `Section` component through the `ActionForm` module.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
@appsmith-bot appsmith-bot added the QA Needs QA attention label Aug 1, 2024
@github-actions github-actions bot added the QA Pod Issues under the QA Pod label Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@albinAppsmith albinAppsmith

Labels
Enhancement New feature or request IDE Navigation Issues/feature requests related to IDE navigation, and context switching IDE Pod Issues that new developers face while exploring the IDE IDE Product Issues related to the IDE Product potential-duplicate This label marks issues that are potential duplicates of already open issues QA Pod Issues under the QA Pod QA Needs QA attention
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Added section component for action forms appsmithorg/appsmith
4 participants
@Nikhil-Nandagopal @hetunandu @appsmith-bot @albinAppsmith