-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Added section component for action forms #35309
Conversation
WalkthroughThis update introduces a new Changes
Assessment against linked issues
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (3)
- app/client/src/pages/Editor/ActionForm/Section/index.tsx (1 hunks)
- app/client/src/pages/Editor/ActionForm/Section/styles.module.css (1 hunks)
- app/client/src/pages/Editor/ActionForm/index.ts (1 hunks)
Files skipped from review due to trivial changes (2)
- app/client/src/pages/Editor/ActionForm/Section/styles.module.css
- app/client/src/pages/Editor/ActionForm/index.ts
Additional comments not posted (4)
app/client/src/pages/Editor/ActionForm/Section/index.tsx (4)
1-2
: Imports look good.The imports of React and the CSS module are appropriate for this component.
4-7
: Interface definition is clear.The
SectionProps
interface is well-defined with optional properties.
9-18
: Component implementation is solid.The
Section
component is well-implemented, adhering to best practices for functional components. The use ofdata-standalone
attribute is a nice touch for conditional styling.
20-20
: Export statement is correct.The
Section
component is correctly exported.
@albinAppsmith Please add unit test cases if possible. |
@sagar-qa007 This is a visual component. I feel writing unit test for this doesn't make sense. |
Description
This PR added section component that can be used in UQI forms
Fixes #34319
Automation
/ok-to-test tags="@tag.Sanity"
🔍 Cypress test results
Tip
🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/10176993550
Commit: 95175f3
Cypress dashboard.
Tags:
@tag.Sanity
Spec:
Wed, 31 Jul 2024 09:09:55 UTC
Communication
Should the DevRel and Marketing teams inform users about this change?
Summary by CodeRabbit
Section
component for improved UI structure and reusability.Section
component, enhancing visual consistency across the application.Section
component through theActionForm
module.