Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Post Adding Spotless JSON formatter the Server Target Files are showing errors #35408

Closed
1 task done
NilanshBansal opened this issue Aug 5, 2024 · 0 comments · Fixed by #35407
Closed
1 task done

[Bug]: Post Adding Spotless JSON formatter the Server Target Files are showing errors #35408

NilanshBansal opened this issue Aug 5, 2024 · 0 comments · Fixed by #35407
Assignees
@NilanshBansal
Labels
Bug Something isn't working Integrations Pod General Issues related to the Integrations Pod that don't fit into other tags. Integrations Product Issues related to a specific integration ok-to-test Required label for CI QA Pod Issues under the QA Pod QA Needs QA attention Query & JS Pod Issues related to the query & JS Pod

Comments

@NilanshBansal
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

Description

After adding the formatter and validator for JSON files in this PR, the spotless formatting is showing errors from target folder which are just temporary files created on building server.

Steps To Reproduce

Run mvn spotless:apply locally.
Ref: https://theappsmith.slack.com/archives/CGBPVEJ5C/p1722847287053259?thread_ts=1722840978.523349&cid=CGBPVEJ5C

Public Sample App

No response

Environment

Deploy Preview

Severity

Low (Cosmetic UI issues)

Issue video log

No response

Version

Local Env
@NilanshBansal NilanshBansal added the Bug Something isn't working label Aug 5, 2024
@NilanshBansal NilanshBansal self-assigned this Aug 5, 2024
@Nikhil-Nandagopal Nikhil-Nandagopal added Deploy Preview Issues found in Deploy Preview Low An issue that is neither critical nor breaks a user flow Local Env labels Aug 5, 2024
@NilanshBansal NilanshBansal added Integrations Pod General Issues related to the Integrations Pod that don't fit into other tags. and removed Low An issue that is neither critical nor breaks a user flow Deploy Preview Issues found in Deploy Preview Local Env labels Aug 5, 2024
@github-actions github-actions bot added the Integrations Product Issues related to a specific integration label Aug 5, 2024
@NilanshBansal NilanshBansal mentioned this issue Aug 5, 2024
Merged
2 tasks
@NilanshBansal NilanshBansal added the ok-to-test Required label for CI label Aug 5, 2024
@github-actions github-actions bot added the Query & JS Pod Issues related to the query & JS Pod label Aug 5, 2024
@abhvsn abhvsn closed this as completed in c888543 Aug 5, 2024
@appsmith-bot appsmith-bot added the QA Needs QA attention label Aug 5, 2024
@github-actions github-actions bot added the QA Pod Issues under the QA Pod label Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NilanshBansal NilanshBansal

Labels
Bug Something isn't working Integrations Pod General Issues related to the Integrations Pod that don't fit into other tags. Integrations Product Issues related to a specific integration ok-to-test Required label for CI QA Pod Issues under the QA Pod QA Needs QA attention Query & JS Pod Issues related to the query & JS Pod
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: ignored target directory for spotless JSON formatting appsmithorg/appsmith
3 participants
@Nikhil-Nandagopal @NilanshBansal @appsmith-bot