-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: ignored target directory for spotless JSON formatting #35407
Conversation
Important Review skippedAuto reviews are limited to specific labels. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the WalkthroughThe recent changes to the Maven project's Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (1)
- app/server/pom.xml (1 hunks)
Additional comments not posted (1)
app/server/pom.xml (1)
162-164
: Great job! The exclusion pattern looks correct.The addition of the
<excludes>
block to exclude JSON files in thetarget
directory will help streamline the build process by ignoring unnecessary files. This is a good practice to ensure that only relevant files are processed.
…35442) Reverts #35407 Reverting as formatter is changing the sorting order of JSON keys, will add back with the config for maintaining order. Ref: https://theappsmith.slack.com/archives/CGBPVEJ5C/p1722929754593669?thread_ts=1722916121.682699&cid=CGBPVEJ5C <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Bug Fixes** - Removed exclusion of JSON files from the build process, allowing all JSON files to be included, which may improve file accessibility but could lead to unwanted files in the output. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
Description
This PR ignores the JSON files present in the
target
directory as it stores the temporary files that are generated during the build.Fixes #35408
Automation
/ok-to-test tags="@tag.Sanity"
🔍 Cypress test results
Warning
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/10245947583
Commit: 405ab04
Cypress dashboard.
Tags: @tag.Sanity
Spec:
It seems like no tests ran 😔. We are not able to recognize it, please check workflow here.
Mon, 05 Aug 2024 09:20:07 UTC
Communication
Should the DevRel and Marketing teams inform users about this change?
Summary by CodeRabbit