Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace Group listing of entity items in New Query tab content #38287

Closed
3 tasks done
Tracked by #37342
ankitakinger opened this issue Dec 20, 2024 · 4 comments
Closed
3 tasks done
Tracked by #37342

Replace Group listing of entity items in New Query tab content #38287

ankitakinger opened this issue Dec 20, 2024 · 4 comments
Assignees
@ankitakinger
Labels
IDE Pod Issues that new developers face while exploring the IDE IDE Product Issues related to the IDE Product potential-duplicate This label marks issues that are potential duplicates of already open issues Task A simple Todo

Comments

@ankitakinger
Copy link
Contributor

ankitakinger commented Dec 20, 2024 •
edited
Loading

  • Replace existing implementation with the EntityGroupedList component in ADS
  • Retain the test ids to not break any unit or integration tests
  • Also, replace the same in CreateNewQueryModal component. This is seen on the UI when a new query is created using action selector for any widget.
Screenshot 2024-12-27 at 5 47 24 PM Screenshot 2024-12-27 at 5 48 05 PM
@ankitakinger ankitakinger mentioned this issue Dec 20, 2024
Open
1 task
@Nikhil-Nandagopal Nikhil-Nandagopal added the Task A simple Todo label Dec 20, 2024
@github-actions GitHub Actions
Copy link

We have found issues that are potential duplicates:

  • [Replace Group listing of entity items in New JS tab content #38288] Replace Group listing of entity items in New JS tab content (92%)
    If any of the issues listed above are a duplicate, please consider closing this issue & upvoting the original one.
    Alternatively, if neither of the listed issues addresses your feature/bug, keep this issue open.

@github-actions github-actions bot added the potential-duplicate This label marks issues that are potential duplicates of already open issues label Dec 20, 2024
@github-actions github-actions bot mentioned this issue Dec 20, 2024
Closed
2 tasks
@ankitakinger ankitakinger added IDE Product Issues related to the IDE Product IDE Pod Issues that new developers face while exploring the IDE labels Dec 20, 2024
@github-actions GitHub Actions
Copy link

We have found issues that are potential duplicates:

  • [Replace Group listing of entity items in New JS tab content #38288] Replace Group listing of entity items in New JS tab content (92%)
    If any of the issues listed above are a duplicate, please consider closing this issue & upvoting the original one.
    Alternatively, if neither of the listed issues addresses your feature/bug, keep this issue open.

1 similar comment
@github-actions GitHub Actions
Copy link

We have found issues that are potential duplicates:

  • [Replace Group listing of entity items in New JS tab content #38288] Replace Group listing of entity items in New JS tab content (92%)
    If any of the issues listed above are a duplicate, please consider closing this issue & upvoting the original one.
    Alternatively, if neither of the listed issues addresses your feature/bug, keep this issue open.

@ankitakinger
Copy link
Contributor Author

Hey team! Please add your planning poker estimate with Zenhub @alex-golovanov @hetunandu

@hetunandu hetunandu self-assigned this Jan 3, 2025
@coderabbitai coderabbitai bot mentioned this issue Jan 8, 2025
Merged
2 tasks
ankitakinger added a commit that referenced this issue Jan 10, 2025
@ankitakinger
chore: Adding Group component in ADS Templates (#38512)
3d97706 
## Description

Adding Group component in ADS Templates to use the same for a single
list of grouped entities in the product.

Fixes [#37615](#37615)
[#37616](#37616)
[#38288](#38288)
[#38287](#38287)

## Automation

/ok-to-test tags="@tag.All"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/12704682977>
> Commit: b62fecb
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=12704682977&attempt=2"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.All`
> Spec:
> <hr>Fri, 10 Jan 2025 09:11:50 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

## Release Notes

- **New Features**
  - Enhanced List component with improved grouping capabilities.
  - Added support for dynamic list rendering with custom children.
  - Introduced `EntityGroupsList` for more flexible group management.
- Added new styled components for better visual representation of lists.
  - Added `LoadMore` styled component for improved UX in entity groups.
- New Storybook examples for `EntityGroupsList` and `EntityGroup`
components.

- **Improvements**
  - Refined List component to support more flexible item rendering.
  - Updated styling for list components.
  - Improved type safety for list-related components.
  - Streamlined code structure for better maintainability.

- **Changes**
  - Removed `GroupedList` component.
  - Updated list rendering across multiple components.
  - Simplified list item management.
  - Expanded public API for `EntityExplorer` module with new exports.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
@coderabbitai coderabbitai bot mentioned this issue Jan 17, 2025
Merged
2 tasks
github-actions bot pushed a commit to Zeral-Zhang/appsmith that referenced this issue Feb 7, 2025
@ankitakinger
chore: Adding Group component in ADS Templates (appsmithorg#38512)
3a58f34 
## Description

Adding Group component in ADS Templates to use the same for a single
list of grouped entities in the product.

Fixes [appsmithorg#37615](appsmithorg#37615)
[appsmithorg#37616](appsmithorg#37616)
[appsmithorg#38288](appsmithorg#38288)
[appsmithorg#38287](appsmithorg#38287)

## Automation

/ok-to-test tags="@tag.All"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/12704682977>
> Commit: b62fecb
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=12704682977&attempt=2"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.All`
> Spec:
> <hr>Fri, 10 Jan 2025 09:11:50 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

## Release Notes

- **New Features**
  - Enhanced List component with improved grouping capabilities.
  - Added support for dynamic list rendering with custom children.
  - Introduced `EntityGroupsList` for more flexible group management.
- Added new styled components for better visual representation of lists.
  - Added `LoadMore` styled component for improved UX in entity groups.
- New Storybook examples for `EntityGroupsList` and `EntityGroup`
components.

- **Improvements**
  - Refined List component to support more flexible item rendering.
  - Updated styling for list components.
  - Improved type safety for list-related components.
  - Streamlined code structure for better maintainability.

- **Changes**
  - Removed `GroupedList` component.
  - Updated list rendering across multiple components.
  - Simplified list item management.
  - Expanded public API for `EntityExplorer` module with new exports.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ankitakinger ankitakinger

Labels
IDE Pod Issues that new developers face while exploring the IDE IDE Product Issues related to the IDE Product potential-duplicate This label marks issues that are potential duplicates of already open issues Task A simple Todo
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Nikhil-Nandagopal @hetunandu @ankitakinger