fix: Add & list tabs padding fixes #35057
Conversation
WalkthroughThe recent changes primarily focus on adjusting padding and layout properties across various components in the IDE. Key modifications include the removal of specific padding properties in components such as Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant IDE
participant Components
User->>IDE: Open "Add Query/JSObject" tab
IDE->>Components: Render UI elements with new padding adjustments
Components-->>IDE: Display updated layout
IDE-->>User: Show refined interface
Assessment against linked issues
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
github-actions
bot
added
IDE Navigation
albinAppsmith
added
ok-to-test
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (7)
- app/client/src/pages/Editor/IDE/EditorPane/JS/Add.tsx (1 hunks)
- app/client/src/pages/Editor/IDE/EditorPane/JS/List.tsx (2 hunks)
- app/client/src/pages/Editor/IDE/EditorPane/Query/Add.tsx (1 hunks)
- app/client/src/pages/Editor/IDE/EditorPane/Query/List.tsx (2 hunks)
- app/client/src/pages/Editor/IDE/EditorPane/components/AddAndSearchbar.tsx (1 hunks)
- app/client/src/pages/Editor/IDE/EditorPane/components/GroupedList.tsx (1 hunks)
- app/client/src/pages/Editor/IDE/EditorPane/components/SegmentAddHeader.tsx (1 hunks)
Files skipped from review due to trivial changes (4)
- app/client/src/pages/Editor/IDE/EditorPane/JS/Add.tsx
- app/client/src/pages/Editor/IDE/EditorPane/components/AddAndSearchbar.tsx
- app/client/src/pages/Editor/IDE/EditorPane/components/GroupedList.tsx
- app/client/src/pages/Editor/IDE/EditorPane/components/SegmentAddHeader.tsx
Additional comments not posted (5)
app/client/src/pages/Editor/IDE/EditorPane/Query/Add.tsx (1)
Line range hint
1-1:
Verify the visual presentation of GroupedList.The removal of
flexPropssimplifies the component usage. Please ensure that the visual presentation remains consistent with the design requirements.app/client/src/pages/Editor/IDE/EditorPane/Query/List.tsx (2)
64-64: Verify the visual alignment of the inner Flex component.The removal of
pxfrom the innerFlexcomponent may affect the horizontal spacing. Please ensure that the visual alignment remains consistent with the design requirements.
50-50: Verify the visual alignment of the outer Flex component.The addition of
px="spaces-3"adjusts the horizontal padding. Please ensure that the visual alignment remains consistent with the design requirements.app/client/src/pages/Editor/IDE/EditorPane/JS/List.tsx (2)
63-63: Verify the visual alignment of the outer Flex component.The addition of
px="spaces-3"adjusts the horizontal padding. Please ensure that the visual alignment remains consistent with the design requirements.
89-89: Verify the visual alignment of the inner Flex component.The removal of
pxfrom the innerFlexcomponent may affect the horizontal spacing. Please ensure that the visual alignment remains consistent with the design requirements.
Description
Fixed padding for add and list view of tab as per design.
Fixes #34529
Automation
/ok-to-test tags="@tag.IDE, @tag.Sanity"
🔍 Cypress test results
Tip
🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/10035415378
Commit: 03296dd
Cypress dashboard.
Tags:
@tag.IDE, @tag.SanitySpec:
Mon, 22 Jul 2024 07:39:55 UTC
Communication
Should the DevRel and Marketing teams inform users about this change?
Summary by CodeRabbit
User Interface Enhancements
Bug Fixes